Ads Manager 2 by Siropu [Paid] 2.8.1

[NealC]

Is it just me, or does the “Custom HTML” field work terribly for everyone?
First of all, when I open it, I can’t see the code. It looks empty. But in reality, the code is there - it’s just invisible.

View attachment 338407


I have to click with the mouse, and only then does it appear.

View attachment 338406


But it can’t really be edited. If you try to place the text cursor anywhere in the code, it doesn’t work. It’s impossible - the cursor always jumps to the very end. You also can’t select part of the code with the mouse.

And it’s not just the mouse issues. You can’t move the cursor with the arrow keys either. You also can’t select code using the Shift key.

I reported this long ago, have to click into it to see the contents. @Siropu needs to get this fixed.

 

[USCSS_Nostromo]

I reported this long ago, have to click into it to see the contents. @Siropu needs to get this fixed.

I copied the page code to Cursor and described the problem. It said that after rendering this field, you need to call
editor.refresh();
or
editor.setSize(null, editor.getScrollInfo().height);

 

[creativeforge]

Hi, is it possible to display the weight of the ads? Especially animated GIFs? It would be very helpful to monitor these quickly from the admin. We keep an eye out for that but sometimes banners over 1.5MB and 2.0MB have slipped in, and we want to avoid that.

Maybe also a warning if someone tries to upload a banner that is beyond the allowed weight? But certainly having the weight of each banner displayed to peruse quickly would be very helpful. Thanks!

 

[briansol]

got a few thousand of these logged last week, all the same media picture.

any ideas? the url certainly doesn't seem long, but that \n is suspicious.

 

[nocte]

any ideas? the url certainly doesn't seem long, but that \n is suspicious.

The column page_url in the xf_siropu_ads_manager_click_fraud table is a TEXT type.

Looking at the query, I assume that it tries to update the column with a new line with the URL with #top at the end and keep the existing lines (-> 1 url per line).

I am quite sure you have a row with a lot of urls in the page_url column.

You could try to change the type to MEDIUMTEXT or LONGTEXT to get it working again for now, till there's an official fix.

 

[creativeforge]

got a few thousand of these logged last week, all the same media picture.

any ideas? the url certainly doesn't seem long, but that \n is suspicious.


View attachment 339979

I tried to ask AI as the URL isn't long. Looks like Xenforo dislikes pasting that here.

 

[Siropu]

@Siropu needs to get this fixed.

It will be fixed in the next release.

Maybe also a warning if someone tries to upload a banner that is beyond the allowed weight?

You can use the admin option "Maximum ad image size" to set a limit.

any ideas? the url certainly doesn't seem long, but that \n is suspicious.

Take a look in ACP > Ads Manager > Click fraud monitor and see if there are entries with multiple urls and how long the data is. That \n at the end adds a new line as it captures multiple clicks and registers each page from where it came.

 

[briansol]

That's where things get fun

- no records







so it seems that 0 records ever made it.

 

[Siropu]

Strange. I have made some changes for the next release.

 

[Siropu]

Siropu updated Ads Manager 2 by Siropu with a new update entry:

Bug Fixes

Fixed Background Banners issue with scrolling and sticky header navbar where banners go below them when option in style property is disabled.
Fixed an issue with carousel parsing options in JS script causing errors.
Fixed an issue with Custom HTML code editor not working as expected.
Fixed an issue with disallowed templates admin option where JS code is still being inserted in the page.

Read the rest of this update entry...

 

[vape.to]

Noticed several bugs when renewing existing ads:

1. when editing existing ad and selecting purchase multiple months, click "save" does not produce an invoice.
2. when using extend/renew from dropdown in existing ad and selecting multiple months, with promo code, promo discount is reflected in Total Cost amount (v2.6.5), but when invoice is produced, promo discount isn't reflected in the amount.
3. Extend/renew ad - Total cost: amount missing v 2.6.6

 

[Joe Link]

@Siropu

With $config['development']['enabled'] = true;
and $config['development']['defaultAddOn'] = 'Addon/MyAddon' configured, new ad templates (_siropu_ads_manager_ad_code.<id>) are automatically added to the configured add-on.

 

[beerForo]

Bug:
Changing ad parameters should not affect current or past ads.
If I sell a promo thread for $10/month and change it to $5/week, it should not affect the live ads, or the past ads stats. I looked in my ads section and in the details, it said I sold a promo thread $5/week instead of a $10/month because I changed the ad parameters after it ran. (These dollar amounts are used as am example.) Expired ads need to reflect the parameters that ran. Live ads should not change after being sold.

 

[ASD1978]

Would this add-on allow me to insert custom banners into each individual node? I have managed to insert a banner into one, just to test, and it appears ok - the problem is the main forum banner is still visible and it hides most of the custom banner?

 

[USCSS_Nostromo]

Hi,

Does this plugin support creating ad placements where users can purchase a text advertisement displayed at the very top of the site (on every page)? The ad would consist of just a few words plus a link.

I'd like to be able to specify the font size, for example 40 or 50 pixels.

Thank you!

 

[ASD1978]

Hi,

Does this plugin support creating ad placements where users can purchase a text advertisement displayed at the very top of the site (on every page)? The ad would consist of just a few words plus a link.

I think it's possible, I'm not in a position to confirm this because I'm not using it for "paid" ads. Sirupo provides excellent support though, and I'm sure they'll be able to advise you.

 

[Siropu]

Does this plugin support creating ad placements where users can purchase a text advertisement displayed at the very top of the site (on every page)? The ad would consist of just a few words plus a link.

It has an ad type called "text" where you can add text, link and optionally an image. There are plenty of positions available by default with the option to add your own very easily.

 

[twollert]

@Siropu:

I just updated the Ads Manager on my forum (2.3.10) from version 2.6.4 to 2.6.6. Unfortunately, this caused an issue in combination with AndyB's "Nofollow manager" add-on. It appears in the stack trace because it extends the Templater class, but the actual error seems to stem from the fact that the Ads Manager update broke the class chain. Could you please look into this?

ErrorException: Template error: [E_USER_WARNING] Cannot call method getDisallowedTemplatesArray on a non-object (NULL) src/XF/Template/Templater.php:1285

Stack-Trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', '/usr/www/users/...', 1285)
#1 src/XF/Template/Templater.php(1285): trigger_error('Cannot call met...', 512)
#2 internal_data/code_cache/templates/l9/s0/public/helper_js_global.php(47): XF\Template\Templater->method(NULL, 'getDisallowedTe...', Array)
#3 src/XF/Template/Templater.php(933): XF\Template\Templater->{closure:internal_data/code_cache/templates/l9/s0/public/helper_js_global.php:9}(Object(Andy\NofollowManager\XF\Template\Templater), Array, NULL)
#4 internal_data/code_cache/templates/l9/s0/admin/helper_js_global.php(12): XF\Template\Templater->callMacro('helper_js_globa...', 'head', Array, Array)
#5 src/XF/Template/Templater.php(933): XF\Template\Templater->{closure:internal_data/code_cache/templates/l9/s0/admin/helper_js_global.php:8}(Object(Andy\NofollowManager\XF\Template\Templater), Array, NULL)
#6 internal_data/code_cache/templates/l9/s0/admin/PAGE_RUN_JOB.php(31): XF\Template\Templater->callMacro('helper_js_globa...', 'head', Array, Array)
#7 src/XF/Template/Templater.php(1818): XF\Template\Templater->{closure:internal_data/code_cache/templates/l9/s0/admin/PAGE_RUN_JOB.php:4}(Object(Andy\NofollowManager\XF\Template\Templater), Array, NULL)
#8 src/XF/Admin/App.php(276): XF\Template\Templater->renderTemplate('PAGE_RUN_JOB', Array)
#9 src/XF/App.php(2571): XF\Admin\App->renderPageHtml('

<form data...', Array, Object(XF\Mvc\Reply\View), Object(XF\Mvc\Renderer\Html))
#10 src/XF/Admin/App.php(156): XF\App->renderPage('

<form data...', Object(XF\Mvc\Reply\View), Object(XF\Mvc\Renderer\Html))
#11 src/XF/Mvc/Dispatcher.php(414): XF\Admin\App->renderPage('

<form data...', Object(XF\Mvc\Reply\View), Object(XF\Mvc\Renderer\Html))
#12 src/XF/Mvc/Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#13 src/XF/App.php(2824): XF\Mvc\Dispatcher->run()
#14 src/XF.php(814): XF\App->run()
#15 admin.php(15): XF::runApp('XF\\Admin\\App')
#16 {main}

Status der Anfrage
array(4) {
  ["url"] => string(109) "/admin.php?tools/run-job&only_ids=425190&_xfRedirect=https%3A%2F%2Fwww.XXX.de%2Fadmin.php%3Fadd-ons%2F"
  ["referrer"] => string(44) "https://www.XXX.de/admin.php?add-ons/"
  ["_GET"] => array(3) {
    ["tools/run-job"] => string(0) ""
    ["only_ids"] => string(6) "425190"
    ["_xfRedirect"] => string(44) "https://www.XXX.de/admin.php?add-ons/"
  }
  ["_POST"] => array(0) {
  }
}

 

[Siropu]

Could you please look into this?

If the error stopped after the upgrade, there is no issue.

 

[nocte]

I just updated the Ads Manager on my forum (2.3.10) from version 2.6.4 to 2.6.6. Unfortunately, this caused an issue in combination with AndyB's "Nofollow manager" add-on. It appears in the stack trace because it extends the Templater class, but the actual error seems to stem from the fact that the Ads Manager update broke the class chain. Could you please look into this?

I got the same errors on 2 installations (upgrade 2.6.5 -> 2.6.6). I don't use any of AndyB's add-ons.

I found no issues after the upgrade, but I think this is a bug and should be resolved tough..