Fixed XF2 upgrade from XF1 - zlib extension dependency

[danger@]

I was just performing an update of XF1 to XF2 on a test instance, and have came across a little problem. Once I accessed the /install/ directory the page crashed with "cannot decode raw data" error (NSURLErrorDomain:-1015) in Safari and Chrome reported ERR_CONTENT_DECODING_FAILED. The problem was there was no php-zlib extension installed (was not required with XF1). The install script should check for this first, because I was only able to find out what is going on by inspecting error logs. The script correctly detected that the curl extension was missing though.

 

[danger@]

BTW, are there any files besides old library/config.php to remove after the upgrade?

 

[Mike]

I guess the header was sent to indicate that the content was compressed before the error relating to the compression actually happened, hence the particular browser behavior you ended up with. I've added a check for the existence of gzencode before we try to use it now.

There aren't other files you have to remove, though you can clean up old files if you want (for example, we don't use anything in the library directory after upgrading).

 

[danger@]

@Mike, thank you. OK I will remove the entire library dir, are there any other files which are not used anymore? I don't like keeping any unnecessary files/scripts around, which may only serve potential security threats.

 

[Mike]

There are a few other files in the root directory and js/ and styles/ directories. You can see what's not in the XF2 package in those directories -- we won't use it out of the box.

(Just in case, I would always recommend taking a backup before deleting files.)

 

[danger@]

@Mike are these files safe to remove?

danger@mbp :( ~/Downloads > diff -qr xenforo_1.5.16a_LICENSENO_full xenforo_2.0.1_LICENSENO_full | grep "Only in xenforo_1.5.16"
Only in xenforo_1.5.16a_LICENSENO_full: INSTALL-UPGRADE.txt
Only in xenforo_1.5.16a_LICENSENO_full/upload: admindav.php
Only in xenforo_1.5.16a_LICENSENO_full/upload: deferred.php
Only in xenforo_1.5.16a_LICENSENO_full/upload: fb_channel.php
Only in xenforo_1.5.16a_LICENSENO_full/upload/install: data
Only in xenforo_1.5.16a_LICENSENO_full/upload/install: language_en.php
Only in xenforo_1.5.16a_LICENSENO_full/upload/install: templates
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: flot
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: flow.js
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: jquery
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: redactor
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: sortable
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: swfupload
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: videojs
Only in xenforo_1.5.16a_LICENSENO_full/upload/js: xenforo
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: Lgpl
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: Minify
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: Sabre
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: XenForo
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: Zend
Only in xenforo_1.5.16a_LICENSENO_full/upload/library: config.php.default
Only in xenforo_1.5.16a_LICENSENO_full/upload: rgba.php
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default: videojs
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: XenForo-small.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: XenForo.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: acp-icons
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: avatars
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: clear.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: color-picker
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: connect_sprite.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: editor
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: favicon.ico
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: gplus.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: gradients
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: icons
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: logo.og.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: logo.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: magnifier.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: node-sprite.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: overlay
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: permissions
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: O_o.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: alien.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: barefoot.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: biggrin.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: cautious.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: coffee.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: confused.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: cool.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: cry.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: devilish.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: eek.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: frown.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: geek.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: giggle.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: inlove.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: laugh.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: mad.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: ninja.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: notworthy.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: poop.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: redface.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: roflmao.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: rolleyes.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: sick.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: sleep.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: smile.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: sneaky.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: speechless.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: thumbsdown.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: thumbsup.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: tongue.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: unsure.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: whistling.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: wink.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo/smilies: x3.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: smilies.doodle
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: twitter-bird.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: warning_stripes.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: widgets
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: xenforo-smilies-sprite.png
Only in xenforo_1.5.16a_LICENSENO_full/upload/styles/default/xenforo: xenforo-ui-sprite.png

 

[Chris D]

That looks about right.

We did release this little add-on (which provides a new CLI command) which actually finds and moves all of the files for you:

https://xenforo.com/community/resources/xf1-cleanup-command.6133/

Once installed it can be executed with the command:

php cmd.php xf:legacy-cleanup