data-app="public"
was because removing that prevented some PWA related code from running. The PWA related code is something that triggered a very specific bug in the version of headless Chromium that is run by Lighthouse.data-app="public"
. It has no effect on its own and has been part of the PAGE_CONTAINER template I think since the release of XF 2.0.0.I don't have any problems neither with lighthouse nor with pagespeed insights since ungraded to Beta 2.If you're running Beta 3 and Lighthouse is now working, there is no reason to removedata-app="public"
. It has no effect on its own and has been part of the PAGE_CONTAINER template I think since the release of XF 2.0.0.
I just shared info that I thought you might find useful.You reported this as a bug but without any actual issues to report we're unable to help.
I have no idea how to do that.If you can use your search console to drill down as to why certain pages once were "valid" and now aren't then that would be useful but without that we have no further insights.
so the 3rd dropdown after I put data-app="public" and the 3rd raise after I remove it will not ring any bell?Nothing was changed in Beta 4 which simply further goes to demonstrate there was never a bug to start with.
I understand that a model "I'm OK he's not OK" is comfortable. But "not recommended" is not "prohibited".1. When we say a release is unsupported and we recommend not to run it in production, we hope that you will heed that valuable advice in the future.
Valid mobile friendly pages went from 2.02k to 1.6k in 2 days. I know that it means nothing to you, so here's another one.
I go to Seach Console/ URL inspection/Test live url and I get "Something went wrong. If the issue persists, try again in a few hours" error for any my forum page (pages from my other sites are tested just fine). I deleted data-app="public" and url testing started to work without errors.
I already know the answer: "nothing wrong with xF2.2, it's Google's problems", but you already applied a fix for lighthouse requests, may be you could also apply a fix for google mobile crawler reguests?
data-app="public"
... which simply further goes to demonstrate there was never a bug to start with (c)There is no doubt Google currently has an issue with this line in the the PAGE_CONTAINER template:
Code:data-app="public"
data-app="public"
line prevents XF from using the Badging API that crashes Google's internal tool browser instance.No response from emailing the issue owner?This cannot be completely fixed until they fix it.
While this is definitly true, I do understand the concerns about headless chormium crashing.It still isn't a bug in our code. I will continue to say it.
navigator.webdriver
being true.As a forum owner, I am not interested to find out who's the fault is it, but rather how to fix it. Bearing in mind that your one-month-old message still got no answer on that bugs.chromium page, here is my question: maybe to leave the idea to turn xF into PWA for now?It still isn't a bug in our code. I will continue to say it.
We use essential cookies to make this site work, and optional cookies to enhance your experience.