Fixed \XF\Entity\User::isShownCaptcha does not behave as expected

[Jake B.]

Affected version

2.1.x

I've only tested in two places so far, but both of them don't actually check this response when rendering the captcha on the form, only when isCaptchaValid is run on submission.

For example - both replying to a thread, and creating a new thread explicitly check $xf.visitor.user_id to determine if a captcha should be shown even if isShownCaptcha returns true for a registered user

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.10).

Change log:

Use a consistent function when checking if CAPTCHA should be shown.

There may be a delay before changes are rolled out to the XenForo Community.