Mysqli\ReplicationAdapter::makeConnection does not behave like Mysqli\Adapter::makeConnection

Affected version


Well-known member
On a connection failure, ReplicationAdapter::makeConnection emits a a php warning/ErrorException" instead of a \XF\DB\Exception.

The ReplicationAdapter also does not support the charset option like the normal adapter does.

Some nice to haves;
  • IMO, it would make sense that getTypeConnection should retry on the 'write' connection instead of the 'read' connection if the connection fails.
  • It would be nice if the mysqli connection timeout was surfaced for both adapters.