Fixed XenForo 2.1.10 messed up Admin page

The first thing I would do is rerun the master data rebuild just in case, but beyond that, I'd recommend disabling add-ons as it's possible there are changes there creating incompatibilities.
 
@Mike

Code:
Server error log
XF\CssRenderException: Error rendering template admin:app.less: ParseError: missing opening `{` in admin:app.less on line 4646, column 1 (on or near line 4646) src/XF/CssRenderException.php:87
Generated by: Unknown account May 27, 2020 at 11:47 AM
Stack trace
4643 |     background-position: center center;
4644 |     color: inherit;
4645 |     fill: currentColor;
*4646*| }
4647 |
------------

#0 src/XF/CssRenderer.php(408): XF\CssRenderException::createFromLessException(Object(Less_Exception_Chunk), 'admin:app.less', '// Note that th...')
#1 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss('admin:app.less', '// Note that th...')
#2 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate('admin:app.less', NULL)
#3 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates(Array, Array, Array)
#4 src/XF/CssWriter.php(53): XF\CssRenderer->render(Array)
#5 css.php(30): XF\CssWriter->run(Array, 0, 1, 'a9e9de6db004247...')
#6 {main}

-------------

Previous Less_Exception_Chunk: ParseError: missing opening `{` in anonymous-file-0.less on line 4646, column 1
4644|     color: inherit;
4645|     fill: currentColor;
4646| }
4647|  - src/vendor/oyejorge/less.php/lib/Less/Parser.php:677
#0 src/vendor/oyejorge/less.php/lib/Less/Parser.php(621): Less_Parser->GetRules(NULL)
#1 src/vendor/oyejorge/less.php/lib/Less/Parser.php(449): Less_Parser->_parse()
#2 src/XF/CssRenderer.php(404): Less_Parser->parse('// Note that th...')
#3 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss('admin:app.less', '// Note that th...')
#4 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate('admin:app.less', NULL)
#5 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates(Array, Array, Array)
#6 src/XF/CssWriter.php(53): XF\CssRenderer->render(Array)
#7 css.php(30): XF\CssWriter->run(Array, 0, 1, 'a9e9de6db004247...')
#8 {main}
Request state
array(4) {
  ["url"] => string(139) "/css.php?css=public%3Anormalize.css%2Cpublic%3Acore.less%2Cadmin%3Aapp.less&s=0&l=1&d=1590593987&k=a9e9de6db004247408031ac2eddd7decb871d244"
  ["referrer"] => string(42) "https://www.localsearchforum.com/admin.php"
  ["_GET"] => array(5) {
    ["css"] => string(52) "public:normalize.css,public:core.less,admin:app.less"
    ["s"] => string(1) "0"
    ["l"] => string(1) "1"
    ["d"] => string(10) "1590593987"
    ["k"] => string(40) "a9e9de6db004247408031ac2eddd7decb871d244"
  }
  ["_POST"] => array(0) {
  }
}
 
So this is add-on related, though it does come from a change -- the last line in this file is now a comment, so it's very likely that the add-on is appending without creating any line breaks and thus is getting caught in the comment.

We're investigating.
 
This is my entire app.less file:

Code:
@_nav-elTransitionSpeed: @xf-animationSpeed;
@_navAccount-hPadding: @xf-paddingLarge;

.m-pageWidth(@min-width: @xf-pageEdgeSpacer)
{
    max-width: @xf-pageWidthMax;
    padding: 0 @xf-pageEdgeSpacer;
    margin: 0 auto;
}

.m-pageInset(@defaultPadding: @xf-pageEdgeSpacer)
{
    padding-left: @defaultPadding;
    padding-right: @defaultPadding;

    // iPhone X/Xr/Xs support
    @supports(padding: max(0px))
    {
        &
        {
            padding-left: ~"max(@{defaultPadding}, env(safe-area-inset-left))";
            padding-right: ~"max(@{defaultPadding}, env(safe-area-inset-right))";
        }
    }
}

.u-anchorTarget
{
    .m-stickyHeaderConfig(@xf-publicNavSticky);
    height: (@_stickyHeader-height + @_stickyHeader-offset);
    margin-top: -(@_stickyHeader-height + @_stickyHeader-offset);
}

.p-pageWrapper
{
    position: relative;
    display: flex;
    flex-direction: column;
    min-height: 100vh;
    .xf-pageBackground();

    .is-modalOverlayOpen &
    {
        & when (unit(xf-default(@xf-overlayMaskBlur, 0)) > 0)
        {
            filter: blur(@xf-overlayMaskBlur);
        }
    }
}

// RESPONSIVE HEADER

.p-offCanvasAccountLink
{
    display: none;
}

@media (max-width: 359px)
{
    .p-offCanvasAccountLink
    {
        display: block;
    }
}

@media (max-width: 359px)
{
    .p-offCanvasRegisterLink
    {
        display: block;
    }
}

{{ include('app_staffbar.less') }}
{{ include('app_header.less') }}
{{ include('app_stickynav.less') }}
{{ include('app_nav.less') }}
{{ include('app_sectionlinks.less') }}
{{ include('app_body.less') }}
{{ include('app_breadcrumbs.less') }}
{{ include('app_title.less') }}
{{ include('app_inlinemod.less') }}
{{ include('app_ignored.less') }}
{{ include('app_username_styles.less') }}
{{ include('app_user_banners.less') }}
{{ include('xb.less') }}
 
the last line in this file is now a comment, so it's very likely that the add-on is appending without creating any line breaks and thus is getting caught in the comment.

POSIX definition of line is strict about the fact that every line (including the last line) must end with a new line character. GitHub highlights it with a tiny red arrow when a file does not contain a trailing new line character. Many text editors/IDEs come with configuration options to include trailing new line character, if missing, on save.
 
We are just rolling out a fix for this.

Shortly you should be able to go to "Tools > Check for upgrades" and check for upgrades again.

There will be a new upgrade available that fixes this issue.

If you prefer, you can also download the fixed version from your account area and upgrade manually.

Watch for the announcement being posted shortly to indicate when it is available.

EDIT: Live now.
 
We are just rolling out a fix for this.

Shortly you should be able to go to "Tools > Check for upgrades" and check for upgrades again.

There will be a new upgrade available that fixes this issue.

If you prefer, you can also download the fixed version from your account area and upgrade manually.

Watch for the announcement being posted shortly to indicate when it is available.

EDIT: Live now.
Xenforo version v2.1.10 Patch 1 and same error :(
 
To be clear, this will involve a second patch release so keep an eye out on the existing announcement thread to know when to try again.
 
Top Bottom