1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Watch This Thread - Overlay

Discussion in 'Resolved Bug Reports' started by Pereira, Apr 15, 2013.

  1. Pereira

    Pereira Well-Known Member

    Minor issue.

    The autofocus attribute gets applied to the wrong radio button in the overlay.



    It works as designed when you open it on its own page.

  2. CyberAP

    CyberAP Well-Known Member

    Also you may not use a "true" value since just 'autofocus' attribute is enough. The same width checked.

    Referring to the bug: the autofocus really should point to the button, not on the options. Because usually we just hit enter when those types of windows appear.
    Pereira and Jeremy like this.
  3. AlexT

    AlexT Well-Known Member

    I just encountered the same issue using XF built-in classes to implement my own overlay. Basically whenever your default choice is not the first choice, the wrong radio button gets the autofocus.
  4. Pereira

    Pereira Well-Known Member

    This issue also applies to the "Watch This Resource" overlay too.

    As far as I know, IE 8 and 9 don't support the singular autofocus attribute. It needs to be autofocus="true" because it's a boolean attribute.

    Then again, does it require an autofocus attribute at all?
  5. Mike

    Mike XenForo Developer Staff Member

    We were ignoring autofocus attributes in overlays, just doing the first form field. Fixed it to check for an autofocus value first.
    Pereira and AlexT like this.

Share This Page