Fixed Watch This Thread - Overlay

Pereira

Well-known member
Minor issue.

The autofocus attribute gets applied to the wrong radio button in the overlay.

watch.PNG

autofocus.PNG

It works as designed when you open it on its own page.

watchthread.PNG
 

CyberAP

Well-known member
Also you may not use a "true" value since just 'autofocus' attribute is enough. The same width checked.

Referring to the bug: the autofocus really should point to the button, not on the options. Because usually we just hit enter when those types of windows appear.
 

AlexT

Well-known member
I just encountered the same issue using XF built-in classes to implement my own overlay. Basically whenever your default choice is not the first choice, the wrong radio button gets the autofocus.
 

Pereira

Well-known member
This issue also applies to the "Watch This Resource" overlay too.

As far as I know, IE 8 and 9 don't support the singular autofocus attribute. It needs to be autofocus="true" because it's a boolean attribute.

Then again, does it require an autofocus attribute at all?
 

Mike

XenForo developer
Staff member
We were ignoring autofocus attributes in overlays, just doing the first form field. Fixed it to check for an autofocus value first.
 
Top