Fixed Upload file button in avatar changer disabled when switching.

Liam W

in memoriam 1998-2020
Reproduced twice.

To reproduce:
  • Open the avatar change overlay, by clicking the Avatar link in the user drop down
  • Delete any existing uploaded avatar, and change to Gravatar
  • Refresh page
  • Open avatar overlay again
  • Click the uploaded Avatar radio button
  • The upload file button remains disabled
Tested on Chrome, here on xF.com
 
I was able to reproduce it last night in Chrome Mac OS X.

I'm not sure the replication steps were the same but they are vaguely similar.
 
I was able to reproduce using Chrome too, followed the exact same steps:
avatar.png
 
I was able to reproduce it, though specifically through NOT clicking on the upload avatar radio. It was important to click on the label for the radio instead.

I have now fixed this. I think this might be because of the HTML structure which has the label in the disabled area. The status was being updated before the radio appeared to change, so a small setTimeout sorted it.
 
Top Bottom