Fixed Unfurling URL's

[Ozzy47]

Affected version

2.1.0

While I can understand a URL in the middle of text needing to be on it 's own line in order to unfurl, it seems strange that if you only post a URL in a post it does not unfurl unless you hit return after the URL to trigger the multiple line.

 

[Ozzy47]

Homepage - Comic-Con Museum

Thank you Prebys Foundation for your generous contribution of $100,000 to support our mission. Comic-Con Museum is funded in part by City of San Diego Cultural Affairs.

comic-conmuseum.org

 

[Ozzy47]

Hmmm, seems this issue has changed in the past hour.

 

[Mike]

Nope, nothing changed. What was the URL?

 

[Ozzy47]

Well it happened multiple times with different URL's. You can see this threadbare more, https://xenforo.com/community/threads/unfurl.155971/page-2

 

[Ozzy47]

https://xenforo.com/community/threads/unfurl.155971/page-3

 

[Mike]

Those are in a forum that isn't viewable to guests, so no information can be fetched for them. (So generally, that's expected.)

 

[Mike]

Worth noting that there are some other example URLs there that I might have to look into more, but for the examples in this thread, this is all as expected.

 

[Ozzy47]

That is a plausible explanation for some of the occurring issues, but something defiantly seems off of you look at the thread in the test forum.

 

[tajhay]

Mike,
Check this out.



First post by ME, i post a link and it DOESNT unfurl.
Third post by ME, i post the same thing and it unfurls.

 

[Chris D]

I think I know the issue and interestingly it may relate to a new Froala behaviour.

Pasting a URL appears to automatically link the URL.

We either need to override that behaviour or still allow those links to be unfurled via our HTML conversion.

 

[Chris D]

View attachment B2E7930C-F3EC-4CA1-9942-F2421897ABDC.MP4

 

[Ozzy47]

Interesting. How would that explain why it happens sporadically though?

 

[Chris D]

It seems iOS is converting the URLs to links automatically, but can't reproduce that on macOS. But that could be one factor towards it appearing to be sporadic.

I'd like to say this is a new behaviour but I'm not certain. I'll have to test it on an older XF version. If anyone gets a chance, the demo system is still using the XF 2.0.10 version of Froala (the new version is in 2.0.11 and 2.1.0) so seeing if URLs are auto linked there would be interesting.

 

[Ozzy47]

At least on 2.1.0 this does seem to be an issue with iOS and the advanced editor.

 

[RobinHood]

View attachment 187523

Did you upload this direct from your phone to the post?!

 

[Chris D]

Yes!

 

[The Dark Wizard]

Yes!

Does not having Push Notifications on an iPhone made you sad ?

 

[Chris D]

Yes!

 

[Ozzy47]

Here is one that does not want to unfurl:

https://www.alarabiya.net