Fixed toGMTString() possibly should be replaced with toUTCString()

refael

Well-known member
Nothing serious here, but thought to note about it.
toGMTString() is used in the setCookie() function in xenforo.js.
toGMTString() is deprecated, and toUTCString() should be used instead.
 
Would be a suggestion rather than a vug report I think. Out of curiosity is there a php version the move was made in. Would save research for them.
 
Oops missed it was a JavaScript function. Still a different avenue of consideration. Just needs to fall in line with current browsers supported. Which it should.
 
I did a bit of testing with this and it seems like a worthwhile change.

Interestingly, XenForo itself doesn't use setCookie with an expiry date anywhere; only session cookies are set with that method in the core.
 
Top Bottom