[TH] User Improvements [Deleted]

[picom]

THanks for this, looks great.

 

[KensonPlays]

So I got this error today, not sure why.

View attachment 169248

I'm unsure on how to fix this?

View attachment 169250View attachment 169251

Any help in this regard would be super helpful. I don't like seeing 'you have errors!' messages haha.

 

[Codemastr]

I'm currently seeing this error. Any solution?

• ErrorException: [E_NOTICE] Trying to get property 'change_date' of non-object (src/addons/KL/UserImprovements/Pub/Controller/Account.php:84)

Great addon overall.

 

[Ozzy47]

I know the developer was supposed to look into that, it was reported back in January. https://xenforo.com/community/threads/kl-user-improvements.134606/post-1209003

 

[DaiAku]

@katsulynx FYI - apparently uninstall misses DB entries:

That would be because uninstalling KL's addon doesn't remove the database entries for it. It's an oversight on his part.

This addon is conflicting with XF2 [8WR] Discord Integration. Which is fine on its face, so tried to uninstall and it is still causing problems. I understand this add-on is free and but having a proper uninstall would be appreciated.

 

[Earth2Luke]

@DaiAku

 

[DaiAku]

View attachment 169570
@DaiAku

Thanks, appreciated. There is also DB entries that do not get removed on uninstall - which really is the big problem - in my case the entry called "discord". We had to delete this entry manually because it was not removed from the DB on uninstall. This kind of things should not really ever happen.

Here was the eventual conclusion in the other thread:

You hit the nail on the head - we shouldn't have to fumble through and possibly break things.

I don't make add-ons for Xenforo or do any DB stuff (obviously) but if I did it would seem like a programming 101 practice to name my DB entries with something that would not possibly conflict with others. So as an example: @Jaxel would name his DB entry discord_8WR while @katsulynx could name his discord_KL so at a bare minimum these kinds of things could not happen.

 

[Lukas W.]

@katsulynx FYI - apparently uninstall misses DB entries:

Thanks for notifying me of this issue. The general code is there, but it might not be working as expected. I'll prioritize this issue and come up with a fix as soon as I can find the time. If you need any help on getting rid of these entries until then, drop me a conversation message and I will assist you.

 

[Lukas W.]

I've fixed both, the undefined index and the non-working change date for the nexf version. Before I'll publish it, I'll need to look into the above reported matter first though, and might also include a compatibility patch for Jaxels add-on, which puts me into a really bad mood though, cause I'm not really unterstanding why I have to sort things out for someone who charges money for his work. Either way, I'll see what I can do.

 

[JoyFreak]

I've fixed both, the undefined index and the non-working change date for the nexf version. Before I'll publish it, I'll need to look into the above reported matter first though, and might also include a compatibility patch for Jaxels add-on, which puts me into a really bad mood though, cause I'm not really unterstanding why I have to sort things out for someone who charges money for his work. Either way, I'll see what I can do.

You’ll be the better person.

 

[DaiAku]

I've fixed both, the undefined index and the non-working change date for the nexf version. Before I'll publish it, I'll need to look into the above reported matter first though, and might also include a compatibility patch for Jaxels add-on, which puts me into a really bad mood though, cause I'm not really unterstanding why I have to sort things out for someone who charges money for his work. Either way, I'll see what I can do.

Well if you change this and start charging for the add-on I would pay happily for it. You have the most popular XF2 add-on here, I see this more of an opportunity - it would make sense that some people would be interested in paying for it.

 

[JoyFreak]

Even if it’s like 5 dollars, it’s something rather than nothing and it will keep everyone happy

 

[rivacom]

Am I missing something on the discord Auth? I gave it my client id and key, pointed discord to redirect to https://domain.com/connected_account.php but i get this error when using it.

 

[kbryant414]

Did you use literally domain.com, or did you put in your own domain?

If your forum was located at https://www.google.com/forum/ you would direct to https://www.google.com/forum/connected_account.php

 

[Pur3x]

Am I missing something on the discord Auth? I gave it my client id and key, pointed discord to redirect to https://domain.com/connected_account.php but i get this error when using it.

had the exact same issue when i installed this addon when i had discord integration, try this https://xenforo.com/community/threads/xf2-8wr-discord-integration-paid.140836/page-7 third post if you have discord integration if not try removing the connected_account.php but back it up first just in case and try again.

 

[rivacom]

Did you use literally domain.com, or did you put in your own domain?

If your forum was located at https://www.google.com/forum/ you would direct to https://www.google.com/forum/connected_account.php

Give me a little credit, no i didn't use domain.com , just using that as the example. My forums are in my root html directory.

 

[rivacom]

had the exact same issue when i installed this addon when i had discord integration, try this https://xenforo.com/community/threads/xf2-8wr-discord-integration-paid.140836/page-7 third post if you have discord integration if not try removing the connected_account.php but back it up first just in case and try again.

I was going to try and do it myself but noticed it in this addon so I figure'd I would give it a shot. Worse case I will have to cave for this if both my first two options do not work out.

 

[kbryant414]

Give me a little credit, no i didn't use domain.com , just using that as the example. My forums are in my root html directory.

No disrespect intended. Troubleshooting is often about eliminating the obvious answers first. It's like being asked 'did you try turning it off and on again?,' or 'did you clear cache and cookies?' Because you posted a url instead of just saying 'connected_account.php' I could see it going either way.

 

[rivacom]

No problem, I wasn't really bent. I've worked in the IT field for a while now and have heard it all lol.

Good news is , for some reason creating a new Application in Discord fixed it.

 

[Lukas W.]

katsulynx updated [KL] User Improvements with a new update entry:

1.0.1

Changelog
Bugfixes & Changes

• Fixed an undefined index error that would pop up if users would not have previously changed their names.
• Resolved an issue that would leave some traces of this add-on in your connected account provider database table upon uninstallation.
• Resolved a potential source of incompatibility with other add-ons that add connected account providers by prefixing...

Read the rest of this update entry...