[TH] Reactions [Deleted]

[Dad.]

The add-on doesnt work with xfmg or xf resources as far as I know.

It does, wonder if there is a bug here. Had a bit of a rough week but will make sure to get a solid round of improvements this next week.

 

[Kangy]

ya, it doesn't work for XFMG on my site either, images in the gallery still show the standard xenForo like

 

[JoyFreak]

It is just that the Alerts does not notify you of a Liked resource, maybe also media but I have not tested.

 

[Edward Dalladay]

I have this plugin installed, I was wondering if there was a way to make it show all the reactions rather than have them appear by clicking a button? like with the ratings addon that is available from another author for 1.5.

 

[Charlie J]

Does this work fine with resources atm? I may purchase soon, but it would be going to a live site (hoping to release soon) and so if it's stable ill purchase maybe soon

 

[JoyFreak]

It works, it's just that you don't get a notification in the Alerts when someone likes your resource but it does add to your Likes though.

 

[Charlie J]

It works, it's just that you don't get a notification in the Alerts when someone likes your resource but it does add to your Likes though.

Ohh right, thank you!

 

[Dan Hawkins]

Importer worked - fab

However, getting constant server errors from the addon (this error was triggered by me rating a "Profile Post" as agree:

Server error log
ErrorException: [E_NOTICE] Undefined index: image_normal src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php:30
Generated by: Dan Hawkins Dec 10, 2017 at 9:05 AM
Stack trace
#0 src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php(30): XF::handlePhpError(8, 'Undefined index...', '/home/arlrebor/...', 30, Array)
#1 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(106): ThemeHouse\Reactions\XF\Str\Formatter->getReactionHtml(Array, Array)
#2 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(29): ThemeHouse\Reactions\XF\Template\Templater->fnReactionList(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\ProfilePost), Array, Array)
#3 [internal function]: ThemeHouse\Reactions\XF\Template\Templater->fnReacts(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\ProfilePost), Array, Array, Array)
#4 src/XF/Template/Templater.php(861): call_user_func_array(Array, Array)
#5 src/addons/ThemeHouse/Reactions/Pub/View/React.php(17): XF\Template\Templater->fn('reacts', Array)
#6 src/XF/Mvc/Renderer/AbstractRenderer.php(77): ThemeHouse\Reactions\Pub\View\React->renderJson()
#7 src/XF/Mvc/Renderer/Json.php(60): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('ThemeHouse\\Reac...', '', Array)
#8 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('ThemeHouse\\Reac...', '', Array)
#9 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#11 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#12 src/XF.php(328): XF\App->run()
#13 index.php(13): XF::runApp('XF\\Pub\\App')
#14 {main}
Request state
array(4) {
  ["url"] => string(46) "/community/reactions/react/profile_post/5084/3"
  ["referrer"] => string(57) "https://apexonlineracing.com/community/members/sean.5502/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(4) {
    ["_xfRequestUri"] => string(29) "/community/members/sean.5502/"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

But there are more, non profile post ratings causing errors too:

ErrorException: [E_NOTICE] Undefined index: image_normal src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php:28
Generated by: Dan Hawkins Dec 10, 2017 at 8:10 AM
Stack trace
#0 src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php(28): XF::handlePhpError(8, 'Undefined index...', '/home/arlrebor/...', 28, Array)
#1 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(106): ThemeHouse\Reactions\XF\Str\Formatter->getReactionHtml(Array, Array)
#2 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(29): ThemeHouse\Reactions\XF\Template\Templater->fnReactionList(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\Post), Array, Array)
#3 [internal function]: ThemeHouse\Reactions\XF\Template\Templater->fnReacts(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\Post), Array, Array, Array)
#4 src/XF/Template/Templater.php(861): call_user_func_array(Array, Array)
#5 src/addons/ThemeHouse/Reactions/Pub/View/React.php(17): XF\Template\Templater->fn('reacts', Array)
#6 src/XF/Mvc/Renderer/AbstractRenderer.php(77): ThemeHouse\Reactions\Pub\View\React->renderJson()
#7 src/XF/Mvc/Renderer/Json.php(60): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('ThemeHouse\\Reac...', '', Array)
#8 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('ThemeHouse\\Reac...', '', Array)
#9 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#11 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#12 src/XF.php(328): XF\App->run()
#13 index.php(13): XF::runApp('XF\\Pub\\App')
#14 {main}
Request state
array(4) {
  ["url"] => string(41) "/community/reactions/react/post/472134/32"
  ["referrer"] => string(78) "https://apexonlineracing.com/community/threads/xenforo-2-0-update.27755/page-9"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(4) {
    ["_xfRequestUri"] => string(50) "/community/threads/xenforo-2-0-update.27755/page-9"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[JoyFreak]

Server error log
ErrorException: Template error: Function reaction is unknown
src/XF/Template/Templater.php:840
Generated by: Ƶuse
Dec 9, 2017 at 1:35 AM
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Function reacti...', '/home/legendo1/...', 840, Array)
#1 src/XF/Template/Templater.php(840): trigger_error('Function reacti...', 512)
#2 internal_data/code_cache/templates/l1/s11/public/alert_post_react.php(9): XF\Template\Templater->fn('reaction', Array, true)
#3 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array)
#4 src/XF/Alert/AbstractHandler.php(67): XF\Template\Templater->renderTemplate('alert_post_reac...', Array)
#5 src/XF/Entity/UserAlert.php(67): XF\Alert\AbstractHandler->render(Object(XF\Entity\UserAlert))
#6 [internal function]: XF\Entity\UserAlert->render()
#7 src/XF/Template/Templater.php(920): call_user_func_array(Array, Array)
#8 internal_data/code_cache/templates/l1/s11/public/alert_macros.php(18): XF\Template\Templater->method(Object(XF\Entity\UserAlert), 'render', Array)
#9 src/XF/Template/Templater.php(643): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array, Array)
#10 internal_data/code_cache/templates/l1/s11/public/account_alerts.php(28): XF\Template\Templater->callMacro('alert_macros', 'row', Array, Array)
#11 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array)
#12 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('account_alerts', Array)
#13 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#14 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:Account\\Aler...', 'public:account_...', Array)
#15 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#16 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#17 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#18 src/XF.php(328): XF\App->run()
#19 index.php(13): XF::runApp('XF\\Pub\\App')
#20 {main}
Request state
array(4) {
["url"] => string(15) "/account/alerts"
["referrer"] => string(28) "https://www.legendofmir.org/"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

 

[Jake B.]

Importer worked - fab

However, getting constant server errors from the addon (this error was triggered by me rating a "Profile Post" as agree:

Server error log
ErrorException: [E_NOTICE] Undefined index: image_normal src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php:30
Generated by: Dan Hawkins Dec 10, 2017 at 9:05 AM
Stack trace
#0 src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php(30): XF::handlePhpError(8, 'Undefined index...', '/home/arlrebor/...', 30, Array)
#1 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(106): ThemeHouse\Reactions\XF\Str\Formatter->getReactionHtml(Array, Array)
#2 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(29): ThemeHouse\Reactions\XF\Template\Templater->fnReactionList(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\ProfilePost), Array, Array)
#3 [internal function]: ThemeHouse\Reactions\XF\Template\Templater->fnReacts(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\ProfilePost), Array, Array, Array)
#4 src/XF/Template/Templater.php(861): call_user_func_array(Array, Array)
#5 src/addons/ThemeHouse/Reactions/Pub/View/React.php(17): XF\Template\Templater->fn('reacts', Array)
#6 src/XF/Mvc/Renderer/AbstractRenderer.php(77): ThemeHouse\Reactions\Pub\View\React->renderJson()
#7 src/XF/Mvc/Renderer/Json.php(60): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('ThemeHouse\\Reac...', '', Array)
#8 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('ThemeHouse\\Reac...', '', Array)
#9 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#11 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#12 src/XF.php(328): XF\App->run()
#13 index.php(13): XF::runApp('XF\\Pub\\App')
#14 {main}
Request state
array(4) {
  ["url"] => string(46) "/community/reactions/react/profile_post/5084/3"
  ["referrer"] => string(57) "https://apexonlineracing.com/community/members/sean.5502/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(4) {
    ["_xfRequestUri"] => string(29) "/community/members/sean.5502/"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

But there are more, non profile post ratings causing errors too:

ErrorException: [E_NOTICE] Undefined index: image_normal src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php:28
Generated by: Dan Hawkins Dec 10, 2017 at 8:10 AM
Stack trace
#0 src/addons/ThemeHouse/Reactions/XF/Str/Formatter.php(28): XF::handlePhpError(8, 'Undefined index...', '/home/arlrebor/...', 28, Array)
#1 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(106): ThemeHouse\Reactions\XF\Str\Formatter->getReactionHtml(Array, Array)
#2 src/addons/ThemeHouse/Reactions/XF/Template/Templater.php(29): ThemeHouse\Reactions\XF\Template\Templater->fnReactionList(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\Post), Array, Array)
#3 [internal function]: ThemeHouse\Reactions\XF\Template\Templater->fnReacts(Object(ThemeHouse\UIX\XF\Template\Templater), false, Object(ThemeHouse\Reactions\XF\Entity\Post), Array, Array, Array)
#4 src/XF/Template/Templater.php(861): call_user_func_array(Array, Array)
#5 src/addons/ThemeHouse/Reactions/Pub/View/React.php(17): XF\Template\Templater->fn('reacts', Array)
#6 src/XF/Mvc/Renderer/AbstractRenderer.php(77): ThemeHouse\Reactions\Pub\View\React->renderJson()
#7 src/XF/Mvc/Renderer/Json.php(60): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('ThemeHouse\\Reac...', '', Array)
#8 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Json->renderView('ThemeHouse\\Reac...', '', Array)
#9 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#11 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#12 src/XF.php(328): XF\App->run()
#13 index.php(13): XF::runApp('XF\\Pub\\App')
#14 {main}
Request state
array(4) {
  ["url"] => string(41) "/community/reactions/react/post/472134/32"
  ["referrer"] => string(78) "https://apexonlineracing.com/community/threads/xenforo-2-0-update.27755/page-9"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(4) {
    ["_xfRequestUri"] => string(50) "/community/threads/xenforo-2-0-update.27755/page-9"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

I haven't seen this error before, I think it could be from a reaction definition that was imported from Post Ratings. Could you try opening all of the reactions and saving them to see if that prevents this error from coming up? If that works I think my guess is right and I'll be able to narrow down the issue and get an actual patch for it

Server error log
ErrorException: Template error: Function reaction is unknown
src/XF/Template/Templater.php:840
Generated by: Ƶuse
Dec 9, 2017 at 1:35 AM
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Function reacti...', '/home/legendo1/...', 840, Array)
#1 src/XF/Template/Templater.php(840): trigger_error('Function reacti...', 512)
#2 internal_data/code_cache/templates/l1/s11/public/alert_post_react.php(9): XF\Template\Templater->fn('reaction', Array, true)
#3 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array)
#4 src/XF/Alert/AbstractHandler.php(67): XF\Template\Templater->renderTemplate('alert_post_reac...', Array)
#5 src/XF/Entity/UserAlert.php(67): XF\Alert\AbstractHandler->render(Object(XF\Entity\UserAlert))
#6 [internal function]: XF\Entity\UserAlert->render()
#7 src/XF/Template/Templater.php(920): call_user_func_array(Array, Array)
#8 internal_data/code_cache/templates/l1/s11/public/alert_macros.php(18): XF\Template\Templater->method(Object(XF\Entity\UserAlert), 'render', Array)
#9 src/XF/Template/Templater.php(643): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array, Array)
#10 internal_data/code_cache/templates/l1/s11/public/account_alerts.php(28): XF\Template\Templater->callMacro('alert_macros', 'row', Array, Array)
#11 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(LiamW\AllRichUsernames\XF\Template\Templater), Array)
#12 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('account_alerts', Array)
#13 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#14 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:Account\\Aler...', 'public:account_...', Array)
#15 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#16 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#17 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#18 src/XF.php(328): XF\App->run()
#19 index.php(13): XF::runApp('XF\\Pub\\App')
#20 {main}
Request state
array(4) {
["url"] => string(15) "/account/alerts"
["referrer"] => string(28) "https://www.legendofmir.org/"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

Do you have the add-on enabled?

 

[JoyFreak]

@Jake B. Yes I have now. I had to disable because of this error.

 

[Jake B.]

@Jake B. Yes I have now. I had to disable because of this error.

I can't replicate this error, and see no reason it should be happening. Could you PM me a list of add-ons that you have installed?

Edit: Never mind, just found a potential cause. Let me get this released and let me know if that doesn't fix it for you

 

[JoyFreak]

I can't replicate this error, and see no reason it should be happening. Could you PM me a list of add-ons that you have installed?

I just checked, and followed the same procedure as before and it works fine. Not sure if it is because I replied to that particular thread that was causing the issue. But then, I did disable, uninstall and remove many add-ons over the weekend, so could have fixed it?

 

[Jake B.]

I just checked, and followed the same procedure as before and it works fine. Not sure if it is because I replied to that particular thread that was causing the issue. But then, I did disable, uninstall and remove many add-ons over the weekend, so could have fixed it?

Yeah, it looks like it was an issue with the way template functions were being registered, so it could even matter the order in which it was installed

 

[ThemeHouse]

ThemeHouse updated [TH] Reactions with a new update entry:

Version 1.0.5 Patch Level 2 Released

Bugs Fixed:

• Potential fix for add-on incompatibilities due to the way template functions were being registered

Read the rest of this update entry...

 

[Nirjonadda]

@Jake B. Reaction count in thread list is only do count from 1st post but can be add option for including Reaction count from all post? Also does not have option disable Reaction count show in thread list?

 

[Jake B.]

That is intentional as the first post is essentially the "main" part of the thread, I thought there was a style property to disable this, but I must have forgotten it. Temporarily, you can disable it by adding `.structItem .reactions-bar { display: !none; }` to your EXTRA.less

 

[KSA]

Im not able to remove other's reaction although all permissions are set correctly.

 

[ThemeHouse]

ThemeHouse updated [TH] Reactions with a new update entry:

Version 1.0.5 Patch Level 3 Released

Bugs Fixed:

• Alert was not received for liked content types that are not supported by [TH] Reactions

Read the rest of this update entry...

 

[KSA]

ThemeHouse updated [TH] Reactions with a new update entry:

Version 1.0.5 Patch Level 3 Released



Read the rest of this update entry...

Does this address my concern above?