[TH] Holidays

[TH] Holidays 2.1.3

No permission to download
@silence Please check out the Tickets. Also get server error log.

Code:
ErrorException: Template error: Invalid argument supplied for foreach() src/addons/ThemeHouse/Holidays/Entity/Holiday.php:21

Generated by: Nirjon Dec 23, 2017 at 3:39 AM

Stack trace

#0 src/addons/ThemeHouse/Holidays/Entity/Holiday.php(21): XF\Template\Templater->handleTemplateError(2, 'Invalid argumen...', '/home/nadda/pub...', 21, Array)
#1 src/XF/Mvc/Entity/Entity.php(139): ThemeHouse\Holidays\Entity\Holiday->getFireworkEffect()
#2 src/XF/Mvc/Entity/Entity.php(97): XF\Mvc\Entity\Entity->get('firework_effect')
#3 internal_data/code_cache/templates/l1/s0/admin/th_holiday_edit_holidays.php(364): XF\Mvc\Entity\Entity->offsetGet('firework_effect')
#4 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array)
#5 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('th_holiday_edit...', Array)
#6 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#7 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('ThemeHouse\\Holi...', 'admin:th_holida...', Array)
#8 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#10 src/XF/App.php(1880): XF\Mvc\Dispatcher->run()
#11 src/XF.php(328): XF\App->run()
#12 admin.php(13): XF::runApp('XF\\Admin\\App')
#13 {main}

Request state

array(4) {
  ["url"] => string(33) "/admin.php?holidays/winter.1/edit"
  ["referrer"] => string(46) "/admin.php?holidays/"
  ["_GET"] => array(1) {
    ["holidays/winter_1/edit"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
 
@silence Please check out the Tickets. Also get server error log.

Code:
ErrorException: Template error: Invalid argument supplied for foreach() src/addons/ThemeHouse/Holidays/Entity/Holiday.php:21

Generated by: Nirjon Dec 23, 2017 at 3:39 AM

Stack trace

#0 src/addons/ThemeHouse/Holidays/Entity/Holiday.php(21): XF\Template\Templater->handleTemplateError(2, 'Invalid argumen...', '/home/nadda/pub...', 21, Array)
#1 src/XF/Mvc/Entity/Entity.php(139): ThemeHouse\Holidays\Entity\Holiday->getFireworkEffect()
#2 src/XF/Mvc/Entity/Entity.php(97): XF\Mvc\Entity\Entity->get('firework_effect')
#3 internal_data/code_cache/templates/l1/s0/admin/th_holiday_edit_holidays.php(364): XF\Mvc\Entity\Entity->offsetGet('firework_effect')
#4 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array)
#5 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('th_holiday_edit...', Array)
#6 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#7 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('ThemeHouse\\Holi...', 'admin:th_holida...', Array)
#8 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#10 src/XF/App.php(1880): XF\Mvc\Dispatcher->run()
#11 src/XF.php(328): XF\App->run()
#12 admin.php(13): XF::runApp('XF\\Admin\\App')
#13 {main}

Request state

array(4) {
  ["url"] => string(33) "/admin.php?holidays/winter.1/edit"
  ["referrer"] => string(46) "/admin.php?holidays/"
  ["_GET"] => array(1) {
    ["holidays/winter_1/edit"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
Yeah pulled it, and I'll get you sorted out once this issue is fixed.
 
The toggle on/off for winter and new year, dont even work?
Doesn't seem to. I've tried toggling this and that off and on and the only time I can even get the fireworks to work is when it's enabled under the Winter options - and then it's this absolutely huge header. But I'll look at it again tomorrow when I'm more awake.
 
The toggle on/off for winter and new year, dont even work?
Okay, do this: enable both Winter and New Year under the Holiday settings under Appearance, then go to the addon options and choose whichever you want to use from the drop-down menu there and click save. Like I said above, though, the fireworks option doesn't work when enabled under Winter - I guess most people wouldn't want to use them together anyway....
 
Last edited:
Do you have the add-on enabled as I am unsure why it isn't showing under Widgets? You should see Holidays under Widgets under Appearance.

Of course, If I didnt have it enabled there wouldnt be a need to disable the snow :S . Updated to latest version, still isnt showing.
 
It's slightly killing me a little that things aren't tested before release. So many bugs across there add-ons that have recently been updated.
 
I got an failed to load resource in the winter mode. The images couldn't load. The files are missing..

2017-12-23_13-12-43.webp
 
Ah, must not have made the output raw, if you search the templates for "snow" you'll see where it inputs the character, just change it from {$holiday.snow.character} to {$holiday.snow.character|raw} (variable name might be slightly different, don't have it in front of me right now)

This option seems to have gone in the current version.
 
Top Bottom