[TH] Bookmarks [Deleted]
- Thread starter ThemeHouse
- Start date
Nirjonadda
Well-known member
Jake B.
Well-known member
Nirjonadda
Well-known member
Not yet, but this is planned
Great Please make this happen ASAP ....
@Jake B. Getting error from Xon Import. Does import are completed?
Code:
ErrorException: [E_NOTICE] Trying to get property of non-object in src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php at line 24
XF::handlePhpError() in src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php at line 24
ThemeHouse\Bookmarks\Import\Data\Bookmark->preSave() in src/XF/Import/Data/AbstractData.php at line 85
XF\Import\Data\AbstractData->save() in src/addons/ThemeHouse/Bookmarks/Import/Importer/XonBookmarks17x.php at line 83
ThemeHouse\Bookmarks\Import\Importer\XonBookmarks17x->stepBookmarks() in src/XF/Import/Runner.php at line 161
XF\Import\Runner->runStep() in src/XF/Import/Runner.php at line 75
XF\Import\Runner->run() in src/XF/Admin/Controller/Import.php at line 231
XF\Admin\Controller\Import->actionRun() in src/XF/Mvc/Dispatcher.php at line 249
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1879
XF\App->run() in src/XF.php at line 328
XF::runApp() in admin.php at line 13
Code:
ErrorException: [E_NOTICE] Trying to get property of non-object src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php:24
Generated by: Nirjon Dec 6, 2017 at 2:56 AM
Stack trace
#0 src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php(24): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/nadda/pub...', 24, Array)
#1 src/XF/Import/Data/AbstractData.php(85): ThemeHouse\Bookmarks\Import\Data\Bookmark->preSave(48)
#2 src/addons/ThemeHouse/Bookmarks/Import/Importer/XonBookmarks17x.php(83): XF\Import\Data\AbstractData->save(48)
#3 src/XF/Import/Runner.php(161): ThemeHouse\Bookmarks\Import\Importer\XonBookmarks17x->stepBookmarks(Object(XF\Import\StepState), Array, 8)
#4 src/XF/Import/Runner.php(75): XF\Import\Runner->runStep('bookmarks', Object(XF\Import\StepState), 8)
#5 src/XF/Admin/Controller/Import.php(231): XF\Import\Runner->run()
#6 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Import->actionRun(Object(XF\Mvc\ParameterBag))
#7 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Import', 'Run', 'html', Object(XF\Mvc\ParameterBag), 'importData', Object(XF\Admin\Controller\Import), NULL)
#8 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#10 src/XF.php(328): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
["url"] => string(21) "/admin.php?import/run"
["referrer"] => string(47) "/admin.php?import/run"
["_GET"] => array(1) {
["import/run"] => string(0) ""
}
["_POST"] => array(1) {
["_xfToken"] => string(8) "********"
}
}
Code:
ErrorException: Template error: Method canBookmark is not callable on the given object (ThemeHouse\UIX\XF\Entity\Node) src/XF/Template/Templater.php:916
Generated by: hmiu Dec 6, 2017 at 3:02 AM
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Method canBookm...', '/home/nadda/pub...', 916, Array)
#1 src/XF/Template/Templater.php(916): trigger_error('Method canBookm...', 512)
#2 internal_data/code_cache/templates/l1/s22/public/th_forum_view_bookmarkLink_bookmarks.php(6): XF\Template\Templater->method(Object(ThemeHouse\UIX\XF\Entity\Node), 'canBookmark', Array)
#3 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array)
#4 src/XF/Template/Templater.php(1304): XF\Template\Templater->renderTemplate('th_forum_view_b...', Array)
#5 internal_data/code_cache/templates/l1/s22/public/forum_view.php(139): XF\Template\Templater->includeTemplate('public:th_forum...', Array)
#6 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array)
#7 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('forum_view', Array)
#8 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#9 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:Forum\\View', 'public:forum_vi...', Array)
#10 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#12 src/XF/App.php(1879): XF\Mvc\Dispatcher->run()
#13 src/XF.php(328): XF\App->run()
#14 index.php(13): XF::runApp('XF\\Pub\\App')
#15 {main}
Request state
array(4) {
["url"] => string(28) "/forums/news.35/page-9"
["referrer"] => string(55) "/forums/news.35/page-10"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
Last edited:
Nirjonadda
Well-known member
Jordyn
Well-known member
Hi,
I keep getting this error pretty much everyday. Disabled for now.
Server error log
Stack trace
Request state
I keep getting this error pretty much everyday. Disabled for now.
Server error log
Code:
ErrorException: [E_RECOVERABLE_ERROR] Argument 1 passed to ThemeHouse\Bookmarks\Pub\Controller\Bookmark::addEditBookmark() must be an instance of ThemeHouse\Bookmarks\Entity\Bookmark, instance of XF\Mvc\Reply\Error given, called in /home/sitetest/public_html/healthforum/src/addons/ThemeHouse/Bookmarks/Pub/Controller/Bookmark.php on line 99 and defined src/addons/ThemeHouse/Bookmarks/Pub/Controller/Bookmark.php:193Stack trace
Code:
#0 src/addons/ThemeHouse/Bookmarks/Pub/Controller/Bookmark.php(193): XF::handlePhpError(4096, 'Argument 1 pass...', '/home/sitetest/publi...', 193, Array)
#1 src/addons/ThemeHouse/Bookmarks/Pub/Controller/Bookmark.php(99): ThemeHouse\Bookmarks\Pub\Controller\Bookmark->addEditBookmark(Object(XF\Mvc\Reply\Error))
#2 src/XF/Mvc/Dispatcher.php(249): ThemeHouse\Bookmarks\Pub\Controller\Bookmark->actionEdit(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(89): XF\Mvc\Dispatcher->dispatchClass('ThemeHouse\\Book...', 'edit', 'html', Object(XF\Mvc\ParameterBag), 'th_bookmark', Object(ThemeHouse\Bookmarks\Pub\Controller\Bookmark), NULL)
#4 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#5 src/XF/App.php(1863): XF\Mvc\Dispatcher->run()
#6 src/XF.php(328): XF\App->run()
#7 index.php(13): XF::runApp('XF\\Pub\\App')
#8 {main}Request state
Code:
array(4) {
["url"] => string(22) "/bookmarks/test.1/edit"
["referrer"] => bool(false)
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}Jake B.
Well-known member
Great Please make this happen ASAP ....
@Jake B. Getting error from Xon Import. Does import are completed?
Code:ErrorException: [E_NOTICE] Trying to get property of non-object in src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php at line 24 XF::handlePhpError() in src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php at line 24 ThemeHouse\Bookmarks\Import\Data\Bookmark->preSave() in src/XF/Import/Data/AbstractData.php at line 85 XF\Import\Data\AbstractData->save() in src/addons/ThemeHouse/Bookmarks/Import/Importer/XonBookmarks17x.php at line 83 ThemeHouse\Bookmarks\Import\Importer\XonBookmarks17x->stepBookmarks() in src/XF/Import/Runner.php at line 161 XF\Import\Runner->runStep() in src/XF/Import/Runner.php at line 75 XF\Import\Runner->run() in src/XF/Admin/Controller/Import.php at line 231 XF\Admin\Controller\Import->actionRun() in src/XF/Mvc/Dispatcher.php at line 249 XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 88 XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 41 XF\Mvc\Dispatcher->run() in src/XF/App.php at line 1879 XF\App->run() in src/XF.php at line 328 XF::runApp() in admin.php at line 13
Code:ErrorException: [E_NOTICE] Trying to get property of non-object src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php:24 Generated by: Nirjon Dec 6, 2017 at 2:56 AM Stack trace #0 src/addons/ThemeHouse/Bookmarks/Import/Data/Bookmark.php(24): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/nadda/pub...', 24, Array) #1 src/XF/Import/Data/AbstractData.php(85): ThemeHouse\Bookmarks\Import\Data\Bookmark->preSave(48) #2 src/addons/ThemeHouse/Bookmarks/Import/Importer/XonBookmarks17x.php(83): XF\Import\Data\AbstractData->save(48) #3 src/XF/Import/Runner.php(161): ThemeHouse\Bookmarks\Import\Importer\XonBookmarks17x->stepBookmarks(Object(XF\Import\StepState), Array, 8) #4 src/XF/Import/Runner.php(75): XF\Import\Runner->runStep('bookmarks', Object(XF\Import\StepState), 8) #5 src/XF/Admin/Controller/Import.php(231): XF\Import\Runner->run() #6 src/XF/Mvc/Dispatcher.php(249): XF\Admin\Controller\Import->actionRun(Object(XF\Mvc\ParameterBag)) #7 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Import', 'Run', 'html', Object(XF\Mvc\ParameterBag), 'importData', Object(XF\Admin\Controller\Import), NULL) #8 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch)) #9 src/XF/App.php(1879): XF\Mvc\Dispatcher->run() #10 src/XF.php(328): XF\App->run() #11 admin.php(13): XF::runApp('XF\\Admin\\App') #12 {main} Request state array(4) { ["url"] => string(21) "/admin.php?import/run" ["referrer"] => string(47) "/admin.php?import/run" ["_GET"] => array(1) { ["import/run"] => string(0) "" } ["_POST"] => array(1) { ["_xfToken"] => string(8) "********" } }
Code:ErrorException: Template error: Method canBookmark is not callable on the given object (ThemeHouse\UIX\XF\Entity\Node) src/XF/Template/Templater.php:916 Generated by: hmiu Dec 6, 2017 at 3:02 AM Stack trace #0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Method canBookm...', '/home/nadda/pub...', 916, Array) #1 src/XF/Template/Templater.php(916): trigger_error('Method canBookm...', 512) #2 internal_data/code_cache/templates/l1/s22/public/th_forum_view_bookmarkLink_bookmarks.php(6): XF\Template\Templater->method(Object(ThemeHouse\UIX\XF\Entity\Node), 'canBookmark', Array) #3 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array) #4 src/XF/Template/Templater.php(1304): XF\Template\Templater->renderTemplate('th_forum_view_b...', Array) #5 internal_data/code_cache/templates/l1/s22/public/forum_view.php(139): XF\Template\Templater->includeTemplate('public:th_forum...', Array) #6 src/XF/Template/Templater.php(1230): XF\Template\Templater->{closure}(Object(ThemeHouse\Reactions\XF\Template\Templater), Array) #7 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('forum_view', Array) #8 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render() #9 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:Forum\\View', 'public:forum_vi...', Array) #10 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View)) #11 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html') #12 src/XF/App.php(1879): XF\Mvc\Dispatcher->run() #13 src/XF.php(328): XF\App->run() #14 index.php(13): XF::runApp('XF\\Pub\\App') #15 {main} Request state array(4) { ["url"] => string(28) "/forums/news.35/page-9" ["referrer"] => string(55) "/forums/news.35/page-10" ["_GET"] => array(0) { } ["_POST"] => array(0) { } }
Fixed the first two errors, but couldn't replicate the third. Try updating once I release this update and see if it's resolved for you, and if not create a ticket with admin details so we can have a look
Got this sorted as well
Nirjonadda
Well-known member
ThemeHouse
Well-known member
ThemeHouse updated [TH] Bookmarks with a new update entry:
1.0.2 Patch Level 2
Read the rest of this update entry...
1.0.2 Patch Level 2
Read the rest of this update entry...
ThemeHouse
Well-known member
Yes, it would've failed at the point that it threw that error
Nirjonadda
Well-known member
So no need to delete any table or log table that what Importer before?
Nirjonadda
Well-known member
Completed, Does we need delete Import log table? How to disable text form visitors tab, only icon show.
Also how to enable Bookmarks text with icon in postbit beacause icon are not visible and very small. Please can you improve icon size?
Nirjonadda
Well-known member
Brad Padgett
Well-known member
I haven't seen many people pay attention to this resource and it's actually a very good one. There are 4 addons I want to buy and I'd like recommendation on if they would work good together or cause problems on my forum.
The 4 addons are [TH] Bookmarks, [TH] Question and Answer Forums, and [TH] Reactions along with Chat 2 by Siropu. I don't intend to have a addon fest with my forum or anything but after that I would slow down on the addons I bought. However, I'd like an update if you think at least the first 3 (since they were created by you) work well together along with any suggestions you may have with Chat 2 by Siropu causing problems. For example, things you may have heard of from user input would be nice to let me know about.
There's a bug with All Rich Usernames and [TH] Reactions where the usernames don't show in color on the forum_list. I will update that thread now and see if you guys are going to fix it or rather the creator of that add-on. I look forward to hearing from you. I'm getting the money on Wednesday.
The 4 addons are [TH] Bookmarks, [TH] Question and Answer Forums, and [TH] Reactions along with Chat 2 by Siropu. I don't intend to have a addon fest with my forum or anything but after that I would slow down on the addons I bought. However, I'd like an update if you think at least the first 3 (since they were created by you) work well together along with any suggestions you may have with Chat 2 by Siropu causing problems. For example, things you may have heard of from user input would be nice to let me know about.
There's a bug with All Rich Usernames and [TH] Reactions where the usernames don't show in color on the forum_list. I will update that thread now and see if you guys are going to fix it or rather the creator of that add-on. I look forward to hearing from you. I'm getting the money on Wednesday.
Jake B.
Well-known member
All of these add-ons should work just fine together, none of them really touch anything in common so there shouldn't be any conflict between them. Haven't heard any reports of issues with Siropu's chat add-on either. As for the Rich Usernames issue you're mentioning, I've replied in the other thread, but this is something I've been unable to replicate. In fact, we don't actually do anything with the forum list (other than adding in the reactions from the first post, but this is in an entirely separate area from what Liam's add-on changes
imno007
Well-known member
It is pretty tiny and inconspicuous. Had to put up a thread showing everyone where to find it, since people were looking for something a little more obvious.
Jake B.
Well-known member
It is pretty tiny and inconspicuous. Had to put up a thread showing everyone where to find it, since people were looking for something a little more obvious.
Changing this to make it more obvious is already planned
I think I'm going to be adding a "main" bookmark button at the top of the page (similar to the one on nodes) and the bookmark post icon will probably be put near the reply/quote button
Nirjonadda
Well-known member
Changing this to make it more obvious is already planned
Great, Please try to add display location option for ordering where its showing, in near posts no or near the reply/quote. I also like the two location with icon and text.
Similar threads
