Fixed Strange behaviour while refreshing the page “cookies notice”

[Fethi.dz]

Affected version

2.1 Beta

Hello,

When refreshing the page the cookies notice in the buttom of the page pops up and quickly disappears after the page is loaded.
This behaviour wasn’t there in the 2.0.10 version.

Tested on iOS 12.1, Safari

Vid:
View attachment 4054E8F4-1D19-4F99-BCCB-5D9F878E379D.MP4

 

[Chris D]

I think this is down to guest page caching (which we have enabled here now) and may be one of those things where the benefits of it outweigh the side effects.

One such side effect is that if the page was rendered fully rather than coming from the cache then we would actually remove this notice from the page entirely, so it doesn't need to be briefly shown before being hidden.

In fact, the current approach may be problematic. If the output which is cached excludes the notice then theoretically some guests may never see the notice at all.

FWIW, we could flip this so it is hidden by default and then made visible if necessary, but that isn't ideal either.

Leave it with us

 

[Mike]

Indeed, this was guest caching related, so there were likely situations where the notice wasn't displayed when it should've been. That's fixed now, as well as the flashing. We had code to handle this already but it wasn't running for the cookie notice.