1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

As Designed "Star Conversations" when selecting a single conversation

Discussion in 'Resolved Bug Reports' started by dutchbb, Jul 13, 2013.

  1. dutchbb

    dutchbb Well-Known Member

    There are two phrases:


    So when selecting a single conversation, there should be an option called "Star Conversation" instead the option "Star Conversations" is always shown.

    Hopefully not reported yet (did search though).
  2. Mike

    Mike XenForo Developer Staff Member

    Do you mean with the "inline moderation" style actions? We always use plural there as it's referring to the selected conversations (even if there's only 1).
  3. Mike

    Mike XenForo Developer Staff Member

    You can see the rest are all plural (and the same with threads, posts, and profile posts).

    The singular version is used within a conversation.
  4. dutchbb

    dutchbb Well-Known Member

    It's about this:

    Schermafbeelding 2013-07-15 om 16.10.34.png

    It just feels wrong since it's directly related to that single selection. But since there are two phrases (singular and plural) I thought it was a bug.

    Edit: ok I understand.
    Last edited: Jul 15, 2013
  5. Jeremy

    Jeremy Well-Known Member

    The rest of those options are plural as well.
  6. dutchbb

    dutchbb Well-Known Member

    Yes I just noticed it as Mike posted it. I assume the benefits do not outweigh the disadvantages (lines of code/performance?) to transform to singular phrases in case of single selection.
  7. Jeremy

    Jeremy Well-Known Member

    Not really, no. Since JavaScript would have to wholly replace text on 1 or 2 selections.

Share This Page