As designed "Star Conversations" when selecting a single conversation

[dutchbb]

There are two phrases:

star_conversation
star_conversations

So when selecting a single conversation, there should be an option called "Star Conversation" instead the option "Star Conversations" is always shown.

Hopefully not reported yet (did search though).

 

[Mike]

Do you mean with the "inline moderation" style actions? We always use plural there as it's referring to the selected conversations (even if there's only 1).

 

[Mike]

You can see the rest are all plural (and the same with threads, posts, and profile posts).

The singular version is used within a conversation.

 

[dutchbb]

It's about this:



It just feels wrong since it's directly related to that single selection. But since there are two phrases (singular and plural) I thought it was a bug.


Edit: ok I understand.

 

[Jeremy]

The rest of those options are plural as well.

 

[dutchbb]

Yes I just noticed it as Mike posted it. I assume the benefits do not outweigh the disadvantages (lines of code/performance?) to transform to singular phrases in case of single selection.

 

[Jeremy]

Not really, no. Since JavaScript would have to wholly replace text on 1 or 2 selections.