Browser issue Spell check not working correctly in Firefox for MacOS

[AndyB]

Affected version

PR10 or whatever version XenForo is running right now.

I'm using Firefox 54.0.1 on MacOS Sierra.

In any editor do this:

1) Type a misspelled word, for example

Unfortunaately

2) Continue typing another word then a space after the second word the red dotted line for the first misspelled word goes away.

 

[Chris D]

It's something that is out of our control unfortunately.

There's a pattern with most rich text editors (that don't use iframes) to actually disable the spell check in Firefox entirely because it's basically bugged. This was reported to Froala (after a similar bug report at the demo forum) and they essentially marked it as something they wouldn't/couldn't fix.

All we can hope for is that Mozilla fix it in Firefox at some point.

 

[AndyB]

Thank you, Chris.

I found the thread you mentioned:

https://github.com/froala/wysiwyg-editor/issues/1432

Will the third party spell checker be implemented?

 

[Chris D]

No it won't be and spell check works great in all browsers except Firefox.

You'd be better off with a Firefox specific spell check extension (hopefully they will work better than the default).

 

[DaveM]

I see that the spell checker on Firferfox does not really work, for a brief period it will underline the word in red but then if you go back it will not give you the correct word options to select from.

Unfortunately I see this as being a bit of a show stopper for my forum?

Just looking at this post it seems that it might sort of work but is not consistent as the word seems to be highlighted at times, so I am not sure what the trigger is that does highlight it?

 

[AndyB]

I submitted a bug report at Mozilla.

https://bugzilla.mozilla.org/show_bug.cgi?id=1400428

 

[AndyB]

We're making progress.

https://bugzilla.mozilla.org/show_bug.cgi?id=1400428

Looks like the issue has to do with this.normalize() method in Froala not being compatible with Firefox.

What is the purpose of this.normalize() and is it needed when Froala is used in XF2?

 

[Lukas W.]

The normalize() method removes empty Text nodes, and joins adjacent Text nodes.

(From w3schools)

It basically cleans up leftovers that appear sooner or later when you generate code with user input.

 

[Chris D]

We're making progress.

https://bugzilla.mozilla.org/show_bug.cgi?id=1400428

Looks like the issue has to do with this.normalize() method in Froala not being compatible with Firefox.

What is the purpose of this.normalize() and is it needed when Froala is used in XF2?

You do realise the other guy commenting on that report, "Stefan", is a Froala developer, right? If anyone, he'd be the person to ask None of the issue relates to any XF code. As it is a standard JavaScript method, the implication here is still that Firefox is generally handling perfectly valid code badly.

Hopefully together they'll figure it out.

 

[RichV]

I found a temporary fixed

To view this content we will need your consent to set third party cookies.
For more detailed information, see our cookies page.

Accept third party cookies

 

[AndyB]

Thank you, Rich.

 

[RichV]

You're welcome Andy.

 

[AndyB]

Froala is working on a fix for the Firefox spell check issue.

Here's a new Github js with the latest version of Froala.

https://github.com/froala/wysiwyg-editor



I tried editing the js/vendor/froala/froala-compiled.js with the latest version from this github, but I'm not sure if that is all that has to be done in order to test. I'm hoping that someone from the XenForo team can take a look at this.

 

[Chris D]

We would have to wait for the next version to be actually released, which will be 2.7.1.

We will update XF to that version as soon as practicably possible.

 

[AndyB]

We would have to wait for the next version to be actually released, which will be 2.7.1.

We will update XF to that version as soon as practicably possible.

Stefan has asked me to test this latest version. Should I be able to just exchange the Froala code in the js/vendor/froala/froala-compiled.js with this latest version, or is it more involved?

 

[Chris D]

Here's a test version I set up using the current files. Seems to work much better on Firefox:

https://jsfiddle.net/xgg23h82/

 

[AndyB]

That is working perfect, Chis.

I let Stefan know it works perfect and lets hope he will release 2.7.1 real soon so you can incorporate it into latest version of XF2.

Thank you.

 

[AndyB]

Hi Chris,

Froala has updated their editor which now fixes the Firefox spell check issue.

https://www.froala.com/wysiwyg-editor/download

I hope we can see this latest version of Froala in the next release of XF2.

Thank you.

 

[Chris D]

Unfortunately there is a regression in Froala 2.7.1 so we won't be updating until Froala 2.7.2 at the earliest. Ideally these bugs will be resolved before we update:

https://github.com/froala/wysiwyg-editor/issues/created_by/mikesul

 

[AndyB]

Thank you, Chris.