Fixed Spam clean not working

[AndyB]

Affected version

XFMG 2.2.2

Spam cleaner not working.

Steps to reproduce:

1. Create a new user called test.
2. Log in as test.
3. Go to media gallery.
4. Add media.
5. Upload file.
6. Log in as admin.
7. Go to Media gallery, select image just uploaded and Unapprove media item.
8. Go to Approval queue and spam clean the media item.

At this point all is well, the temp user is banned and the media item is soft deleted.

9. Go to Admin control panel and lift ban on user temp.
10. Go to media gallery and undelete image.
11. Now unapprove the image.
12. Go to Approval queue and spam clean the media item.

You will see nothing happens. Something is preventing the spam cleaner from working.

 

[Chris D]

With the exact steps you describe, this is expected, and not exclusive to XFMG.

The user has already been spam cleaned so via the approval queue we skip the spam cleaning action. This is so we don't attempt to spam clean the same user multiple times if they have multiple items in the approval queue.

The correct method to undo a spam clean is not to simply lift the ban, but instead to restore the user.

This can be done from Admin > Logs > Spam cleaner log.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.5).

Change log:

Only skip spam cleaning via the approval queue if the user was spam cleaned recently.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Chris D]

That said, the restriction as it stands is slightly bullish so we've changed it to only skip cleaning if the cleaning happened recently, within the last couple of minutes.

The comments about reversing a spam clean properly still stand though. You can obviously still run into this if you follow your reproduction steps within 2 minutes, but that shouldn't be very common.