Similar threads [Paid] 8.5

[polyp2000]

I found a bug in the Similar Threads Addon , when using enhanced search,
it is possible in come circumstances for the method getSimilarThreadsEnhanced to receive a
NULL value for "currentNodeId".

This is passed into the Elastic Search query unchecked , this causes a lot of Server Errors (something like this)

• GuzzleHttp\Exception\ClientException: Similar threads error: Client error: POST http://{OBFUSCATED AWS ES URL }/xenforo-prod/xf/_search resulted in a 400 Bad Request response: {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"field name is null or empty"}],"type":"illegal_ar (truncated...)
• src/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:113

This doesnt seem to manifest in a visible way on the front facing part of the forums but this is very spammy and making a LOT
of request to elastic search that we know will fail before they are sent.

My fix , is to just

if (!$currentNodeId){
return;
}

right after the check for excluded forums (line 527).

This prevents the query from being sent and acts as if no results were returned.

Please could you look into this and maybe patch the plugin so that we dont have to
manage updates seperately?

Thanks

Nick

 

[polyp2000]

I found a bug in the Similar Threads Addon , when using enhanced search,
it is possible in come circumstances for the method getSimilarThreadsEnhanced to receive a
NULL value for "currentNodeId".

This is passed into the Elastic Search query unchecked , this causes a lot of Server Errors (something like this)

• GuzzleHttp\Exception\ClientException: Similar threads error: Client error: POST http://{OBFUSCATED AWS ES URL }/xenforo-prod/xf/_search resulted in a 400 Bad Request response: {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"field name is null or empty"}],"type":"illegal_ar (truncated...)
• src/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:113

This doesnt seem to manifest in a visible way on the front facing part of the forums but this is very spammy and making a LOT
of request to elastic search that we know will fail before they are sent.

My fix , is to just

if (!$currentNodeId){
return;
}

right after the check for excluded forums (line 527).

This prevents the query from being sent and acts as if no results were returned.

Please could you look into this and maybe patch the plugin so that we dont have to
manage updates seperately?

Thanks

Nick

I have now realised that this error is triggered when the "Same Forum" option is selected in the Addon Options.
disabling this also stops the errors from being flagged. Either way it feels there needs to be a bit more work done on this
plugin with regards to supporting Elastic Search (I use AWS for this)

 

[AndyB]

AndyB updated Similar threads with a new update entry:

See description

Similar threads v5.3 changes:

Fixed issue dealing with getting the correct node_id during thread creation. Now properly supports URL portion.

Read the rest of this update entry...

 

[DerTobi75]

Hi,

it looks like a Javascript is still fired, even if both Options to show Similar Threads on Thread Creation is disabled. The Screenshot was made on the Forumlists Quick Thread Form, after entering the Title, ...

Regards,

Tobi

 

[DerTobi75]

There would be no point disabling both options.

Meant those two settings:

 

[dinhphucv]

Doesn't work with Elasticsearch 7.0.1

 

[rfc0001]

Doesn't work with Elasticsearch 7.0.1

Major Elasticsearch versions usually have breaking changes. Does XF Enhanced Search even support 7.x yet?

ETA: Looks like Andy is running Elasticsearch 7 himself: https://www.xf2addons.com/threads/install-java-and-elasticsearch.363/post-2596

 

[dinhphucv]

Major Elasticsearch versions usually have breaking changes. Does XF Enhanced Search even support 7.x yet?

ETA: Looks like Andy is running Elasticsearch 7 himself: https://www.xf2addons.com/threads/install-java-and-elasticsearch.363/post-2596

According to XenForo Enhanced Search 2.1.1 changelog, it is compatible with Elasticsearch 7.x

 

[rfc0001]

I'm seeing similar Elasticsearch GuzzleHttp errors using Andy's Change Date add-on after upgrading to Elasticsearch 7.0.1, although no such errors for Similar threads.

 

[AndyB]

AndyB updated Similar threads with a new update entry:

See description

Similar threads v5.4 changes:

Improved compatibility for XF v2.1.2 and ElasticSearch v7.0 or newer.

Read the rest of this update entry...

 

[darkeye]

Can I use this add on just for one site or can I use it for more sites?

 

[AndyB]

AndyB updated Similar threads with a new update entry:

See description

Similar threads v5.5 changes:

Fixed issue when quick thread is disabled. JavaScript error was showing when quick thread was used.

Read the rest of this update entry...

 

[JoyFreak]

Does this not work on iPhone 8 Safari? Using the latest iOS software and similar threads don’t show.

 

[AndyB]

AndyB updated Similar threads with a new update entry:

See description

Similar threads v5.6 changes:

Similar threads in responsive now shows just the thread titles.

Read the rest of this update entry...

 

[JoyFreak]

AndyB updated Similar threads with a new update entry:

See description



Read the rest of this update entry...

Not a big fan of the similar threads collapsing when clicking away but good job on the responsive fix.

 

[AndyB]

AndyB updated Similar threads with a new update entry:

See description

Similar threads v5.8 changes:

Added additional CSS to the andy_similarthreads.less template. This allows adjusting the margin of the similar threads block.

Similar threads v5.7 changes:

Removed auto close function. Similar threads now remain displayed while composing message.

Read the rest of this update entry...

 

[JoyFreak]

AndyB updated Similar threads with a new update entry:

See description



Read the rest of this update entry...

Wise move removing the auto close function.

 

[Stuart Wright]

Andy FYI I installed this on AVForums.com today (along with about 60 other addons having migrated to XF2) and it absolutely killed the server.
Too many connection errors for over an hour while we tracked down what the issue was.
I was convinced it was a DOS attack.
Disabling Similar Threads stopped it completely.
Has it been tested on a big forum?

 

[Recep Baltaş]

Our forum, 150K daily unique. But you should use it with Elasticsearch. Otherwise, it might be a burden for the MySQL server.

 

[Danny88]

Andy FYI I installed this on AVForums.com today (along with about 60 other addons having migrated to XF2) and it absolutely killed the server.
Too many connection errors for over an hour while we tracked down what the issue was.
I was convinced it was a DOS attack.
Disabling Similar Threads stopped it completely.
Has it been tested on a big forum?

25M messages forum with Elastic shouldn't be any problem.