Show Older Items is missing since update

[beerForo]

Affected version

2.3.8

Show Older Items is missing in search since the last update. Search results now end at 10 pages with no button available to show more.

 

[420]

I just realized this myself and came to post a bug report about it.

Hope they fix it fast, this is a huge feature, I wonder if it will affect SEO and indexed pages?

 

[briansol]

Seems to be working ok for me -- i have enhanced search. are you guys running regular?

 

[beerForo]

Regular.

 

[beerForo]

I don't see it here on XF either.

 

[digital-forum]

--- SearchController.php.OLD    2026-01-31 11:09:24.019393277 +0100
+++ SearchController.php    2026-01-31 11:06:31.257218063 +0100
@@ -233,7 +233,7 @@
         if (
             $search->search_order === 'date'
             && $search->result_count > $perPage
-            && $page === $maxPage
+            && $page >= $maxPage
         )
         {
             $lastResult = $resultSet->getLastResultData($lastResultType);

 

[modified]

I'm having the same issue after the v2.3.8 upgrade. Using the regular search.

 

[beerForo]

And 2.3.9 did not fix it.

 

[webbouk]

Thanks for the heads-up - same here on 2.3.9

 

[briansol]

--- SearchController.php.OLD    2026-01-31 11:09:24.019393277 +0100
+++ SearchController.php    2026-01-31 11:06:31.257218063 +0100
@@ -233,7 +233,7 @@
         if (
             $search->search_order === 'date'
             && $search->result_count > $perPage
-            && $page === $maxPage
+            && $page >= $maxPage
         )
         {
             $lastResult = $resultSet->getLastResultData($lastResultType);

This code exists (===) in 2.3.7 so i'm not sure why the 2.3.8 upgrade would break it.

There must be another area that effects this?

2.3.6 is slightly different with the double ==.

$maxPage = ceil($search->result_count / $perPage);
        if ($search->search_order == 'date'
            && $search->result_count > $perPage
            && $page == $maxPage)
        {
            $lastResult = $resultSet->getLastResultData($lastResultType);
            $getOlderResultsDate = $searcher->handler($lastResultType)->getResultDate($lastResult);
        }
        else
        {
            $getOlderResultsDate = null;
        }

 

[beerForo]

I'm having the same issue after the v2.3.8 upgrade. Using the regular search.

 

[webbouk]

Replacing this from 2.3.9 ....

      if (
         $search->search_order === 'date'
         && $search->result_count > $perPage
         && $page === $maxPage
      )
      {
         $lastResult = $resultSet->getLastResultData($lastResultType);
         $lastResultHandler = $searcher->handler($lastResultType);
         $getOlderResultsDate = $lastResultHandler->getResultDate($lastResult);
      }
      else
      {
         $getOlderResultsDate = null;
      }

To this from the earlier version 2.3.6 .....

        if ($search->search_order == 'date'
            && $search->result_count > $perPage
            && $page == $maxPage)
        {
            $lastResult = $resultSet->getLastResultData($lastResultType);
            $getOlderResultsDate = $searcher->handler($lastResultType)->getResultDate($lastResult);
        }
        else
        {
            $getOlderResultsDate = null;
        }

...adds a working button to 'View older results' as such....




However, the page pagination then starts at '1' to '10' whereas you'd expect it to be '11' to '20' (etc)....




I don't know if doing so affects other functionality though, perhaps @Chris D could shed some light on it?


(/src/XF/Pub/Controller/SearchController.php)

 

[chillibear]

Since I finally got round to bumping a board from 2.2 to 2.3.9 I came looking to see if there had been a resolution or response from XF yet. I'd certainly prefer the previous functionality or at least to know why that was an issue and needed removing.

 

[ehd]

I've been aksed by users, too why this is missing.

 

[beerForo]

I've been aksed by users, too why this is missing.

That's how it was brought to my attention and I had to tell them to use google (site search) until it was resolved.

 

[mverive]

Bumping max results to the permitted 1000 max helps somewhat, but our board goes back over two decades (imported from vBulletin, and I think UBB before that) so sometimes even that isn't enough.

 

[JimH]

One of our staff noticed this as well. We are a XenForo Cloud-hosted forum with Enhanced Search, and this issue appeared when we took the 2.3.8 update last week. I suspect this is more complicated than just the 2.3.8 update though. We also have a self-host instance created from a pre-update backup of our Cloud site. It's 2.3.7 without Enhanced Search (clean install of 2.3.7 + cloud backup - Enhanced Search) and it has this problem also.

 

[briansol]

yeah, 2.3.8 and 2.3.7 have the issue. 2.3.6 has different code (== vs ===) as noted above and I believe that was the last known good configuration..

No thoughts on why it changed yet, or what the implications of moving it back to == may cause.