Fixed 'Show older items' does not show if filters match no results in 'last X days'

[36degrees]

Affected version

v2.1.8; also reproduced on xenforo.com

If you user the filter interface to show (for example) photos added by a certain user, but that user has not posted within the time limit set by 'Only show media added within the last X days' in the Media Gallery settings, you see 'There is no media matching your filters.' with no option to 'Show older items'.

As an example from the gallery on this site, 'The Dark Wizard' posted 1 photo in 2014, which you can see here (by manually adding &no_date_limit=1 to the URL):

Media

xenforo.com

However, if you use the filter controls you see no photos, with no way to extend the search (without manually altering the URL):

Media

xenforo.com

Steps to reproduce​

1. Set 'Only show media added within the last X days' to a relatively short number (for example, 90 days)
2. Use the filter interface to search for photos owned by a user who has not posted anything within that time period

Expected result​

You should at least see the option to 'Show older items'.

Additionally, it would be good to consider if:

• the gallery could automatically extend to search the full library rather than restricting to the last X days.
• the phrase could indicate that only a certain time period was consdiered, for example ''There is no media matching your filters posted within the last 90 days'

Actual result​

You see no results, with the message 'There is no media matching your filters.' and no option to 'Show older items'.

 

[36degrees]

It'd also be good if, where the user has already clicked 'Show older items' the filter interface preserved that choice, rather than resetting to only show photos posted in the last X days.

 

[36degrees]

Ah, I now see https://xenforo.com/community/threa...is-sometimes-no-show-older-items-link.183946/ which might be a duplicate, but it'd be good to verify that this works when filtering by user as well.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFMG release (2.2.1).

Change log:

Ensure the date limit disabler is displayed even when media lists are filtered.

There may be a delay before changes are rolled out to the XenForo Community.