Fixed Service creators declare function _save() as public

[Sim]

Affected version

2.0.4

Service creators for Media, Album and TranscodeEnqueuer declare their _save() function as public, where all other service creators I checked use protected.

Code affected:

• XFMG\Service\Media\Creator::_save()
• XFMG\Service\Album\Creator::_save()
• XFMG\Service\Media\TranscodeEnqueuer::_save()

From my understanding, the only place the _save() function should be called is from the trait code XF\Service\ValidateAndSavableTrait::save(), so we really should not be exposing this function as public?

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XFMG release (2.0.6).

Change log:

Change method visibility in some service classes.

Any changes made as a result of this issue being resolved may not be rolled out here until later.