Jon W
Well-known member
While "discussing" with Adam Howard that all protected methods should begin with an underscore (and all methods beginning with a single underscore should be protected), I noticed that the following methods have been incorrectly marked as public in the XenForo core:
library/XenForo/ControllerAdmin/Language.php
_getLanguageAddEditResponse(array $language)
library/XenForo/ControllerPublic/InlineMod/Post.php
_getInlineModPostModel()
_getPostModel()
_getPrefixModel()
library/XenForo/ControllerPublic/InlineMod/ProfilePost.php
_getInlineModProfilePostModel()
library/XenForo/ControllerPublic/InlineMod/Thread.php
_getInlineModThreadModel()
_getThreadModel()
_getPrefixModel()
library/XenForo/DataWriter/Discussion.php
_verifyTitle(&$title)
library/XenForo/DataWriter/PollResponse.php
_postSave()
_postDelete()
Other than the data-writers, these all seem pretty harmless, but thought I would point it out just in case you didn't have enough other things going on.
library/XenForo/ControllerAdmin/Language.php
_getLanguageAddEditResponse(array $language)
library/XenForo/ControllerPublic/InlineMod/Post.php
_getInlineModPostModel()
_getPostModel()
_getPrefixModel()
library/XenForo/ControllerPublic/InlineMod/ProfilePost.php
_getInlineModProfilePostModel()
library/XenForo/ControllerPublic/InlineMod/Thread.php
_getInlineModThreadModel()
_getThreadModel()
_getPrefixModel()
library/XenForo/DataWriter/Discussion.php
_verifyTitle(&$title)
library/XenForo/DataWriter/PollResponse.php
_postSave()
_postDelete()
Other than the data-writers, these all seem pretty harmless, but thought I would point it out just in case you didn't have enough other things going on.