1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Methods incorrectly marked as public

Discussion in 'Resolved Bug Reports' started by Jon W, Nov 22, 2012.

  1. Jon W

    Jon W Well-Known Member

    While "discussing" with Adam Howard that all protected methods should begin with an underscore (and all methods beginning with a single underscore should be protected), I noticed that the following methods have been incorrectly marked as public in the XenForo core:

    library/XenForo/ControllerAdmin/Language.php
    _getLanguageAddEditResponse(array $language)

    library/XenForo/ControllerPublic/InlineMod/Post.php
    _getInlineModPostModel()
    _getPostModel()
    _getPrefixModel()

    library/XenForo/ControllerPublic/InlineMod/ProfilePost.php
    _getInlineModProfilePostModel()

    library/XenForo/ControllerPublic/InlineMod/Thread.php
    _getInlineModThreadModel()
    _getThreadModel()
    _getPrefixModel()

    library/XenForo/DataWriter/Discussion.php
    _verifyTitle(&$title)

    library/XenForo/DataWriter/PollResponse.php
    _postSave()
    _postDelete()

    Other than the data-writers, these all seem pretty harmless, but thought I would point it out just in case you didn't have enough other things going on. :whistle:
     
    G-O-D and Digital Doctor like this.
  2. Adam Howard

    Adam Howard Well-Known Member

    This has some significance of interest
     
  3. Jon W

    Jon W Well-Known Member

    In what sense?
     
    Mike Creuzer likes this.
  4. Mike

    Mike XenForo Developer Staff Member

    Not a huge deal, but sorted anyway. Thanks. :)
     
    sonnb, Jon W and Slavik like this.

Share This Page