Search Improvements

Search Improvements 2.13.1

No permission to download
i also noticed that leaving the keyword blank doesn't work, but using * does, despite having 'allow empty search' checked.
 
I also seem to be getting a lot of errors related to this addon:

Code:
Server error log
ErrorException: {"sort":[{"date":"desc"}],"docvalue_fields":["discussion_id","user","date"],"_source":false,"size":"250","query":{"bool":{"filter":[{"term":{"user":1065}},{"terms":{"type":["post","thread"]}},{"term":{"thread":12894}}],"must_not":[{"exists":{"field":"hidden"}},{"terms":{"node":[49,225]}}]}}} src/XF/Error.php:75
Generated by: Unknown account Mar 29, 2019 at 3:57 PM
Stack trace
#0 src/XF.php(187): XF\Error->logError('{"sort":[{"date...', false)
#1 src/addons/SV/SearchImprovements/XFES/Elasticsearch/Api.php(19): XF::logError('{"sort":[{"date...')
#2 src/addons/XFES/Search/Source/Elasticsearch.php(153): SV\SearchImprovements\XFES\Elasticsearch\Api->search(Array)
#3 src/XF/Search/Search.php(164): XFES\Search\Source\Elasticsearch->search(Object(SV\SearchImprovements\XF\Search\Query\Query), '250')
#4 src/XF/Repository/Search.php(34): XF\Search\Search->search(Object(SV\SearchImprovements\XF\Search\Query\Query))
#5 src/XF/Pub/Controller/Search.php(395): XF\Repository\Search->runSearch(Object(SV\SearchImprovements\XF\Search\Query\Query), Array, true)
#6 src/XF/Pub/Controller/Search.php(111): XF\Pub\Controller\Search->runSearch(Object(SV\SearchImprovements\XF\Search\Query\Query), Array)
#7 src/addons/SV/SearchImprovements/XF/Pub/Controller/Search.php(55): XF\Pub\Controller\Search->actionSearch()
#8 src/XF/Mvc/Dispatcher.php(321): SV\SearchImprovements\XF\Pub\Controller\Search->actionSearch(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Search', 'Search', Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\Search), NULL)
#10 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\Search), NULL)
#11 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#12 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#13 src/XF.php(390): XF\App->run()
#14 index.php(20): XF::runApp('XF\\Pub\\App')
#15 {main}
Request state
array(4) {
  ["url"] => string(86) "/search/search?c%5Bthread%5D=12894&c%5Busers%5D=crampicide&order=date&search_type=post"
  ["referrer"] => bool(false)
  ["_GET"] => array(4) {
    ["/search/search"] => string(0) ""
    ["c"] => array(2) {
      ["thread"] => string(5) "12894"
      ["users"] => string(10) "crampicide"
    }
    ["order"] => string(4) "date"
    ["search_type"] => string(4) "post"
  }
  ["_POST"] => array(0) {
  }
}
 
unless im misinterpreting what you're saying there, i think i have a bug:

View attachment 199183
Whoops, Fixed for the next version.

i also noticed that leaving the keyword blank doesn't work, but using * does, despite having 'allow empty search' checked.
Fixed for the next version

I also seem to be getting a lot of errors related to this addon:

Code:
Server error log
ErrorException: {"sort":[{"date":"desc"}],"docvalue_fields":["discussion_id","user","date"],"_source":false,"size":"250","query":{"bool":{"filter":[{"term":{"user":1065}},{"terms":{"type":["post","thread"]}},{"term":{"thread":12894}}],"must_not":[{"exists":{"field":"hidden"}},{"terms":{"node":[49,225]}}]}}} src/XF/Error.php:75
Generated by: Unknown account Mar 29, 2019 at 3:57 PM
Stack trace
#0 src/XF.php(187): XF\Error->logError('{"sort":[{"date...', false)
#1 src/addons/SV/SearchImprovements/XFES/Elasticsearch/Api.php(19): XF::logError('{"sort":[{"date...')
#2 src/addons/XFES/Search/Source/Elasticsearch.php(153): SV\SearchImprovements\XFES\Elasticsearch\Api->search(Array)
#3 src/XF/Search/Search.php(164): XFES\Search\Source\Elasticsearch->search(Object(SV\SearchImprovements\XF\Search\Query\Query), '250')
#4 src/XF/Repository/Search.php(34): XF\Search\Search->search(Object(SV\SearchImprovements\XF\Search\Query\Query))
#5 src/XF/Pub/Controller/Search.php(395): XF\Repository\Search->runSearch(Object(SV\SearchImprovements\XF\Search\Query\Query), Array, true)
#6 src/XF/Pub/Controller/Search.php(111): XF\Pub\Controller\Search->runSearch(Object(SV\SearchImprovements\XF\Search\Query\Query), Array)
#7 src/addons/SV/SearchImprovements/XF/Pub/Controller/Search.php(55): XF\Pub\Controller\Search->actionSearch()
#8 src/XF/Mvc/Dispatcher.php(321): SV\SearchImprovements\XF\Pub\Controller\Search->actionSearch(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Search', 'Search', Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\Search), NULL)
#10 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\SearchImprovements\XF\Pub\Controller\Search), NULL)
#11 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#12 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#13 src/XF.php(390): XF\App->run()
#14 index.php(20): XF::runApp('XF\\Pub\\App')
#15 {main}
Request state
array(4) {
  ["url"] => string(86) "/search/search?c%5Bthread%5D=12894&c%5Busers%5D=crampicide&order=date&search_type=post"
  ["referrer"] => bool(false)
  ["_GET"] => array(4) {
    ["/search/search"] => string(0) ""
    ["c"] => array(2) {
      ["thread"] => string(5) "12894"
      ["users"] => string(10) "crampicide"
    }
    ["order"] => string(4) "date"
    ["search_type"] => string(4) "post"
  }
  ["_POST"] => array(0) {
  }
}
Make sure "Log Search DSL" option is disabled.
 
@Xon i am a little bit confused about that.. :unsure:

Screenshot 2019-03-30 15.41.21.webp

EDIT: After upgrading Search Improvements 2.2.2 the Health check was okay. 👍
 
One of the add-ons had a changed licence file which doesn't work so well. Should be fixed now.
Even after upload files (re-downloaded addon), rebuild addon, re-run check file health check, I still got warning

20-11-44.webp
 
Add-on Enhancement Request

Current Situation: XenForo 2.x allows for "Extra sitemap URLs" to be included within the XenForo sitemap. This is used by those of us who have developed custom pages outside the standard XenForo structure/page system. This currently creates an issue for us with the default search functioning within Xenforo. These "Extra sitemap urls" are completely ignored by the current XenForo search and even Enhanced Search.

Request: Would it be possible to extend this add-on or your Elastic Search Essentials add-on to scan these additional urls for at least title and description meta data, and if possible content, so that these extra urls/pages can be included within the XenForo search results?
 
Can anyone confirm or deny that XFES is able to correctly use Master/Slave setup ?

Im running an optimize job now and Im seeing most of the selects are hitting the master instead of the read replica?

Comments appreciated.

N
 
XFES doesn't use MySQL, it talks to ElasticSearch.

XenForo's MySQL search sends queries to the master unless you have something else doing query routing.
 
If XFES doesnt use MySQL then how on earth does the data get into Elastic Search in the first place -
I assumed data is collected from MySQL and pushed to Elastic Search to be indexed?

Perhaps im misunderstanding what optimise does?
What is happening during the "optimise" process that would cause our master database to be receiving
a LOT of reads?

Thanks

N.


XFES doesn't use MySQL, it talks to ElasticSearch.

XenForo's MySQL search sends queries to the master unless you have something else doing query routing.
 
XenForo Search queries the back-end search system for a pile of content types + content ids, it then reads the database to load those. This should only be 2-3 queries for content type at most, if there are more then you have an add-on behaving poorly
 
Small question, despite what it says in the options, putting "0" (zero) as Weighting does not make a result disappear (it simply goes below the rest)

Is this expected ?
 
Top Bottom