Fixed Safari/iOS file upload over AJAX

[Aayush]

Upload via Safari seems to be working fine for me.

 

[Chris D]

I think we need to reopen this. Seems that iOS and Safari have huge issues with file upload elements in AJAX forms.

 

[Chris D]

Not attachments but the basic file upload element over AJAX.

 

[Aayush]

Heres some more information I found while debugging:

All the requests are made on the Edit Resource page. Tested on Safari.

1. Successful: This the request when I select the option "Delete the current icon".

------WebKitFormBoundarym7hycS8DUACXOUUR
Content-Disposition: form-data; name="icon_action"

delete
------WebKitFormBoundarym7hycS8DUACXOUUR

2. Successful: This the request when I select a file to be uploaded.

------WebKitFormBoundarylwwBDJOpGBS6kJcJ
Content-Disposition: form-data; name="upload"; filename="icon.jpg"
Content-Type: image/jpeg

------WebKitFormBoundarym7hycS8DUACXOUUR

3. Failed: This the request when I select no icon to be uploaded. The upload field isn't even touched here.

------WebKitFormBoundaryf6ZV5aNBRkALlEfA
Content-Disposition: form-data; name="upload"; filename=""
Content-Type: application/octet-stream


------WebKitFormBoundaryf6ZV5aNBRkALlEfA

Feel free to ping me if I can help.

 

[Aayush]

It's an issue with Safari. I am not sure if it's a bug, but the solution is to remove the empty file fields from the form before uploading the content.

As you can see from the request form data. There is no empty upload field in the successful requests.
Something like this should work for you.

$('input[type=file]',form).each(function() {
        var files = $(this).prop('files');
        if ( files != undefined && files.length <= 0 ) {
            formData.delete($(this).attr('name'));              
        }
    });

Source: https://stackoverflow.com/questions...n-safari-ios-and-os-x-broke-after-last-update

 

[Chris D]

Heh, pretty much just written that exact code.

That has been rolled out here now so @Aayush and @DragonByte Tech you should find editing resources works fine now.

 

[Aayush]

Heh, pretty much just written that exact code.

That has been rolled out here now so @Aayush and @DragonByte Tech you should find editing resources works fine now.

Will test and let you know if there are still any issues.

 

[DragonByte Tech]

I can confirm that I am able to edit resources here without issue now. Thanks


Fillip