Please tell me you will never... Do this....

[Adam Howard]

Skimlinks and VerticalResponse

So they've added adware and spam into the core product. Nice going Internet Brands.

1) Internet Brands decided to rely on a 3rd party product, rather then code something

2) Internet Brands decided we should be paying a 3rd party provider to use the product we already paid for from Internet Brands (vBulletin)

3) Security software does not like their 3rd party service provider (some individuals will get a warning or not even be able to access the 3rd party provider's site).

4) Use of their services (the 3rd party provider) has been blocked by some mail servers and by association, your community could also be blocked or classified as spam.

5) Some of the ads by Skimlinks have been flagged by security software, so using it can also get your site flagged

A job well done Internet Brands.

So I just want to know... That XenForo.... Would never do this to their customers?!

(The quote is from a post I made on vBulletin's Support Site)

 

[EQnoble]

anyway, where is the best place to add the Skimlink code

I did this as a way to not have to edit core xf code and it could seriously use an admin interface but it does what it should without needing to fix anything on an upgrade... http://xenforo.com/community/threads/xxad-xenxero-skimlinks-viglink-integration.16821/
In this instance you would just paste your skimlinks code into a template as per the instructions in that post and modify it for your needs.

_

If you want to manually add the code you can add it to:


Edit Template: PAGE_CONTAINER

right before the closing </body> tag

Find:

</xen:hook>
</body>

Paste your skimlinks code in like so...

</xen:hook>
<script type="text/javascript" src="http://s.skimresources.com/js/EXAMPLE.skimlinks.js"></script>
</body>

You will need to do this after every upgrade and in either your Master Style or individually in every style you want this to appear in.

 

[mrGTB]

So what is the difference between adding it at the very bottom of the: page_container_js_body

I've read a few people saying that's where they put it, but other saying the template you mentioned. Just wondering which is the best of the two to put it. Here was the guide for the other method.

Link: http://xenforo.com/community/threads/how-to-implement-skimlinks-on-your-site.12807/

 

[EQnoble]

I would guess that it should load last...maybe? I wouldn't know...however...this is pasted from skimlinks:

Copy and paste this code snippet into your site template just before the

</body>​

tag. ​

This tag is at the very end of your page, probably in your footer. ​

See an example of implemented code »​

I just figured it is best to do what the people who made it said to do since there is probably some reasoning for it. I have some .js files that need to load after certain things and some that need to be in the head because of the nature of what they are doing...not sure if that is the case with skimlinks so I just followed the leader.

 

[mrGTB]

Yeah, I know about putting it just before the </body> tag. If you add it at the very bottom of that other page_container_js_body template after the closing </script> I mentioned above, that's exactly also where the code is put. Just before that closing body tag. Both templates do the same job putting the code before the closing </body> tag (if you view your page source), just wondering which of the two (if any) is best to go with adding the code in?

The difference between the two templates, is the one you use is also making use of many other templates all linked to it, unlike the other one which links to none. But still works fine getting skimlinks to apprear in threads.

 

[EQnoble]

Hmm..well as long as <xen:if is="{$cronLink}"><img src="{$cronLink}" width="1" height="1" alt="" style="display: none" /></xen:if>
that doesn't interfere I would suppose then it would basically be the same thing. Try it. If it works it works. I just used the xen:hook because it was the closest thing to the </body> tag.

 

[mrGTB]

I'm not sure myself, which was why I asked to make double sure it was in the correct template. LOL

My main concern was that the template you use that has many others attached to it, seems very much to be a "Global template" and I don't want Skimlinks having access to post links on Private forums, or Paid Subscription ones. So, I've gone with using the same template your using, but wrapped it in a conditional so only guests see Skimlinks added on forums and they will only have the same access as guests too (not able to view some forums or content on them to add links).

<xen:if is="!{$visitor.user_id}">
<script type="text/javascript" src="http://s.skimresources.com/js/XXXXXXXXXX.skimlinks.js"></script>
</xen:if>

 

[Paul B]

Where can additional JavaScript be placed?
Additional JavaScript can be placed in the PAGE_CONTAINER, page_container_js_head or page_container_js_body templates. If PAGE_CONTAINER is used, it can be placed anywhere in the template. If page_container_js_head is used, it will be included in the head section of PAGE_CONTAINER. If page_container_js_body is used, it will be included in the body section of PAGE_CONTAINER, after the footer. It depends on the JavaScript to a large extent; some require to be placed in the head, some in the body.

http://xenforo.com/community/threads/frequently-asked-questions.5183/#post-181112

 

[mrGTB]

Skimlinks is required to be placed in the Body right before the closing </body> tag.

SKIMLINKS CODE
</body>
</html>

 

[EQnoble]

Realistically I think this script just needs to be after the content you want it to effect...right before the closing of the body tag would make the most sense for that since all the content would be before it and there for effected.

 

[mrGTB]

Yeah, I know what you mean it doesn't have to be directly above the </body> tag. just before it after all other content is finished with. Ideally, this would be best placed in a template only pulling the Skimlinks code in "Threads Displayed", by that I mean not being pulled on Members Profiles or other possible sensitive areas we're it might have the effect of turning some words into links. Basically, being limited to thread content (posts made) only.

I'm always a bit iffy when code like this is going into a Globally used template, for obvious reasons like that. At least with the conditional I mentioned above wrapped around it, means it's stopping Skimlinks from accessing areas like Members User CP, because they are treated as a guest with no access to view that area.

 

[mrGTB]

Just thought I should report here that Skimlinks is taking no notice of conditionals used in XenForo to only show the links to guests (visitors) only and not logged-in members. Just spotted it happening on my own forum.

This conditional below is not working as it should with Skimlinks. Even logged-in as a member or admin I can still see the skimlinks.

<xen:if is="!{$visitor.user_id}">
<script type="text/javascript" src="http://s.skimresources.com/js/XXXXXXXXXX.skimlinks.js"></script>
</xen:if>

 

[feldon30]

Just thought I should report here that Skimlinks is taking no notice of conditionals used in XenForo to only show the links to guests (visitors) only and not logged-in members. Just spotted it happening on my own forum.

This conditional below is not working as it should with Skimlinks. Even logged-in as a member or admin I can still see the skimlinks.

<xen:if is="!{$visitor.user_id}">
<script type="text/javascript" src="http://s.skimresources.com/js/XXXXXXXXXX.skimlinks.js"></script>
</xen:if>

That would suggest that the conditional is not written correctly or not working properly.

 

[mrGTB]

Oddly it's working now stopping the links from being shown, think I know why it didn't before and was related to a FireFox plug-in I was using (now removed).

 

[EQnoble]

This should work for you...what you have there looks like it says show to anyone logged in...which is the opposite of what I think you want. I could be wrong though.

<xen:if is="{$visitor.user_id}">
 
<!--This content will show to logged in members..display nothing-->
 
<xen:else />
 
<script type="text/javascript" src="http://s.skimresources.com/js/***********.skimlinks.js"></script><!--This content will show to guests...include skimlinks-->
 
</xen:if>

 

[mrGTB]

It works fine now as before, the problem was cause by a plug-in called CookiePie (even though is wasn't actually activated at the time). Since removing it that permission I posted works like it should only showing links to guests.

 

[EQnoble]

Ahhh i missed the ! before the { in your post .... gotcha now.

 

[mrGTB]

No problem, just wanted to make clear the permission works perfectly fine. Just that FF plug-in causing the issue because it's a browser cookie storage based one.

 

[trilogy33]

Skimlinks

Anyone else seeing their GET requests taking forever to complete? Upwards of nine seconds!!
Ajaxload is going nuts.
Related to this:
http://xenforo.com/community/threads/skimlinks-js-browser-issues-in-opera-ie7.21580
But on every browser.

 

[mrGTB]

Not having issues with pages loading slow using skimlinks that I can see. But after reading this I decided to run the install test to make sure skimlinks was working right and is wasn't. Seems added the permission wrapped around the JavaScript to only show it to guests stopped it from working. I just removed that conditional and I'm not seeing keywords I know should be getting converted into links by Skimlinks doing so, such as the keywords "forum software" leading to vBulletin. which was the case when I installed skimlinks on the MyBB forum I ran.

From what I can see it's not even working on my forum, even though the skimlinks test now says it's installed correctly.

 

[trilogy33]

Thanks.

I've just this second switched providers to Vig on my main style. It makes a huge difference.
It was basically crippling one link in particular, the Admin Control Panel link (top right) in my main DXF style.
Whilst skim was reading the request, it was "unclickable" so was really concerned for other ajax powered buttons.
Reported the anomaly into Skim. One request toppped out at over 28 seconds!