phpBB: Attachments in private messages are not imported

[Kirby]

Affected version

1.5.2

$attachments = $this->sourceDb->fetchAll("
    SELECT *
    FROM attachments
    WHERE attach_id > ? AND attach_id <= ?
        AND is_orphan = 0
        AND post_msg_id > 0
        AND in_message = 0
    ORDER BY attach_id
    LIMIT {$limit}
", [$state->startAfter, $state->end]);

Attachments with in_message = 1 are from private messages and the code ignores them

 

[Endeavour]

Sad to see not a single one of your reported issues with the phpbb importer has been adressed?

phpBB: Deletion status of threads / posts is ignored

phpBB 3.3 introduced a soft-deletion feature for threads (topics.topic_visibility = 2) & posts (posts.post_visibility = 2). The importer code unfortunately treats every value > 0 as visible which causes soft-deleted threads & posts imported from phpBB to be normally visible in XenForo.

xenforo.com

phpBB: Thread watches email notification setting is not imported correctly

XFI\Import\Importer\PhpBB::stepThreads $subs = $this->sourceDb->fetchPairs(" SELECT user_id, notify_status FROM topics_watch WHERE topic_id = {$oldThreadId} "); This code assumes that field notify_status is set to 1 if the user wants to receive notifications via email. But this...

xenforo.com

@Brogan @Kier

 

[Kirby]

@Endeavour
You missed some

phpBB: Custom user field values for type date are not converted

When importing from phpBB with a user profile field of type date, XenForo imports the existing value litereally: if (isset($choiceLookUps[$fieldId])) { $fieldInfo = $choiceLookUps[$fieldId]; $fieldChoiceId = max(0, $user["pf_$fieldId"] - 1); // option ids are 0 keyed, values are 1 keyed...

xenforo.com

PhpBB: Forum watches are not being imported

Threas watches are being imported, but forum watches are not - this seems somewhat inconsistent.

xenforo.com

PhpBB: LogicException: Column 'question' is required and has an empty value while importing XF:Poll

#0 src/XF/Import/Data/EntityEmulator.php(328): XF\Import\Data\EntityEmulator->getWriteData() #1 src/XF/Import/Data/AbstractEmulatedData.php(71): XF\Import\Data\EntityEmulator->insert(73, Object(XF\Db\Mysqli\Adapter)) #2 src/XF/Import/Data/AbstractData.php(129)...

xenforo.com