Fixed Paypal processor is not extendable

[Xon]

In payment_callback.php, XenForo_UserUpgradeProcessor_PayPal is directly created rather than going through the XenForo_Application::resolveDynamicClass or using a trampoline method like CssOutput::run()

This is required if you want to change how the paypal processor reacts to events, without using webserver redirection trips to a new copy of payment_callback.php.

 

[Sadik B]

In payment_callback.php, XenForo_UserUpgradeProcessor_PayPal is directly created rather than going through the XenForo_Application::resolveDynamicClass or using a trampoline method like CssOutput::run()

This is required if you want to change how the paypal processor reacts to events, without using webserver redirection trips to a new copy of payment_callback.php.

Yes this is a terrible PITA if you want to do anything with paypal. Technically this is not really a bug but how they chose to implement this. I just created a new payment_callback_custom.php copying most of the code from payment_callback and adding my own methods and using this new file as the IPN endpoint.

 

[Mike]

This is a reasonable change to make. This code predates the generic class extension stuff (as originally it was type specific).