1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Design Issue Paypal processor - subscr_signup event treated as unknown upgrade

Discussion in 'Resolved Bug Reports' started by Xon, Apr 26, 2016.

  1. Xon

    Xon Well-Known Member

    Paypal sends a subscr_signup notification event, which gets logged into the transaction log as Unknown Upgrade/Unknown Account.

    This adds noise and makes it harder to determine actual Unknown Upgrade/Unknown Account events.

    Logging this as a recurring signup and silently doing nothing with this event would be preferable.
     
    eva2000 likes this.
  2. Mike

    Mike XenForo Developer Staff Member

    This is sort of half design issue and half as designed.

    The design issue relates to the rough inability to actually display any of the user/upgrade details (without big hacks). The log table was originally generally designed for internal use, so the primary relationship is to one of the user upgrade state tables. If no action is being taken, we won't have a record to insert into these tables, so we can'd easily display the upgrade or user involved (it could potentially be done with some string parsing on the "custom" field). In hindsight, as a general logging/debugging tool, this isn't ideal.

    The as designed part relates to this being a general logging/debugging tool that logs everything (from PayPal). While it stands to reason that if they receive subscr_signup, they should receive subscr_payment, we have seen plenty of weird things from PayPal's callbacks. By silencing one of these messages, it may interfere with some amount of debugging, so I'd rather not do that. You should be able to do this yourself if you wanted to in the next release by extending the class and returning a false log type.

    What I'm looking at doing is tweaking the message for a few of these situations to at least have a more descriptive message.

    Worth noting that this is sort of a moot point -- or at least a different point -- in the long term, in light of XF2's more generic payment system/approach.
     
    Xon, Mouth, NixFifty and 1 other person like this.

Share This Page