Not a bug Overlay deCache form submit not calling onClose event?

[Uniphix]

I am not sure if this is a bug but for some reason when I look through the XenForo js code I am noticing that if you don't setup a cache method that it should deCache correctly.

Well when I submit a form or something that I don't want cached it should deCache that overlay is my understanding. Although what happens is when I manually close the overlay by calling $form.closest('.xenOverlay').overlay().close(); it does not call the onClose event for some reason.

 

[Uniphix]

Nevermind, I believe this is working as attended, it was because I was doing

data-cache-overlay rather than data-cacheOverlay or data-cacheoverlay

 

[Uniphix]

I noticed that what you guys did was that you changed all the data('cacheOverlay') to data('cacheoverlay') which is what is messing a few of my addons. i really think that it should support either

data-cache-overlay, data-cacheOverlay or even data-cacheoverlay. But apparently data-cache-overlay = "cacheOverlay" in javascript, and where data-cacheOverlay = "cacheoverlay"... Wished it was case-insensitive. because it means I have a lot of fixing to do...

 

[Chris D]

XenForo 1.2 brought with it a much needed upgrade from jQuery 1.4.x to jQuery 1.10.x.

At some point around jQuery 1.5.x, jQuery decided to make a fundamental change to force all data attributes to be lower case.

It has been known about for some time, and it was advised to prepare for this very situation:

http://xenforo.com/community/threads/html-5-data-attributes-and-case-sensitivity.15609/