Fixed Nested quotes import problem

[imthebest]

I'm migrating from vB 3.8. One of my posts contains this:

[quote=user1][quote=user2;3142018]what user2 said[/quote]
what user1 said[/quote]

But xenForo is importing the nested quotes bad:

[quote="user1][quote=user2, post: 3142018"]what user2 said[/quote]
what user1 said[/quote]

Is this a bug?

 

[Jeremy]

If you are talking about the change to the inner quote; no. It converted it to XenForo's format.

 

[Jake Bunce]

@Super120

I am seeing a possible bug here.

library/XenForo/Importer/vBulletin.php

					if (stripos($post['pagetext'], '[quote=') !== false)
					{
						if (preg_match_all('/\[quote=("|\'|)(?P<username>[^;]*);\s*(?P<postid>\d+)\s*\1\]/siU', $post['pagetext'], $quotes, PREG_SET_ORDER))
						{
							$post['quotes'] = array();

							foreach ($quotes AS $quote)
							{
								$quotedPostId = intval($quote['postid']);

								$quotedPostIds[] = $quotedPostId;

								$post['quotes'][$quote[0]] = array($quote['username'], $quotedPostId);
							}
						}
					}

This piece specifically:

(?P<username>[^;]*)

Try changing it to this:

(?P<username>[^;\]]*)

The original code is bounds-matching the name with a semicolon only which would overrun in your example. The new code adds a right bracket to the bound so it can't escape from the first quote tag.

Moving to bugs for dev review. In the meantime please try that fix and re-run the import. Let me know if it works.

 

[imthebest]

Well in fact I was using the cli importer but I'll test and let you know.

 

[Jake Bunce]

Well in fact I was using the cli importer but I'll test and let you know.

The one stored at library/XFCliImporter? That importer has the same piece of code.

 

[Mike]

The fix seems reasonable -- it's certainly safer in that it's less likely to "over write", but has the potential to not rewrite something it potentially should.