Fixed Moderator actions still shows in tools

[RichardKYA]

Hello,

If I have a moderator group with these forum permissions...



...they can not view the "moderator actions", but the link still displays in the tools drop down...



...and clicking it just triggers this error message...



....so why does it still display? Is it for some reason that I am overlooking?

Thank you

 

[Zynektic]

I am probably wrong, but where you add them as a moderator, is the permission ticked there too if it makes any difference?

 

[Jeremy]

There is not.

 

[RichardKYA]

I am probably wrong, but where you add them as a moderator, is the permission ticked there too if it makes any difference?

I'm not too sure what you mean? Add them where?

 

[RichardKYA]

There is not.

Hi @Jeremy,

There is not what?

some reason that I am overlooking?

...or...

any difference?

 

[Zynektic]

I was just on about the area you add a Moderator, you can tick permissions there and also on the usergroup permissions, whether either of them made a difference if one is checked and the other is not set to allow but if Jeremy was replying to me then I guess not.

 

[RichardKYA]

Oh OK, I haven't added them as a moderator anywhere, they are a super mod, but I was going to break down the "Manage (move, merge, etc.) thread by anyone:" permissions because I don't like them all being clumped together. Some mods I want to be able to move threads, but others not, same goes for editing threads by anyone, merging threads, etc. Anyway, as I was about to start breaking these down, I noticed that "Moderator Actions" remains in the tools, even though they can't use it, but they still have all the other moderator permissions apart from "Manage (move, merge, etc.) thread by anyone:".

 

[Jeremy]

I was replying that there isn't a moderator permission to show that link. It depends on $canViewModeratorLogs, but I would need to look up the code for that, of which, I cannot do on my phone.

 

[Mike]

There's an inconsistency in the permission check here. The link is based on the result of
canViewThreadModeratorLog() which checks for one of a bunch of permissions. The actual action only checks (roughly) one of those.

 

[RichardKYA]

There's an inconsistency in the permission check here.

Can this be reproduced on your installation or is it something that seems isolated to mine?

**EDIT** I've just seen it's been moved to Bug Reports, so that answers my above question.

 

[imthebest]

There's an inconsistency in the permission check here. The link is based on the result of
canViewThreadModeratorLog() which checks for one of a bunch of permissions. The actual action only checks (roughly) one of those.

Sorry I didn't catch you.

Actually what permission controls the ability for moderators to see the Moderator Actions link?

 

[RichardKYA]

I think what he is saying is that it checks a bunch of permissions and that there isn't actually any "one" permission that allows the link to viewable, but the actual action of viewing the moderators actions themselves, only checks one permission and this is what is causing the inconsistency.

 

[Chris D]

These ones specifically in case you're interested:

 

[Chris D]

This is fixed now, thanks.

 

[imthebest]

So now what specific permission controls the display of the "Moderator Actions"?

 

[Chris D]

These ones specifically in case you're interested:

View attachment 108264

 

[imthebest]

These ones specifically in case you're interested:

View attachment 108264

So now a moderator needs to have all those 6 permissions enabled otherwise he is not going to be able to see the moderator actions?

 

[Chris D]

No. They need to have any one of those permissions.