1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Moderator actions still shows in tools

Discussion in 'Resolved Bug Reports' started by RichardKYA, Jun 11, 2015.

  1. RichardKYA

    RichardKYA Well-Known Member

    Hello,

    If I have a moderator group with these forum permissions...

    Screen Shot 2015-06-11 at 18.44.57.jpg

    ...they can not view the "moderator actions", but the link still displays in the tools drop down...

    Screen Shot 2015-06-11 at 18.42.25.jpg

    ...and clicking it just triggers this error message...

    Screen Shot 2015-06-11 at 18.47.08.jpg

    ....so why does it still display? Is it for some reason that I am overlooking?

    Thank you
     
  2. Zynektic

    Zynektic Well-Known Member

    I am probably wrong, but where you add them as a moderator, is the permission ticked there too if it makes any difference?
     
  3. Jeremy

    Jeremy XenForo Moderator Staff Member

    There is not.
     
  4. RichardKYA

    RichardKYA Well-Known Member

    I'm not too sure what you mean? Add them where?
     
  5. RichardKYA

    RichardKYA Well-Known Member

    Hi @Jeremy,

    There is not what?

    ...or...

     
  6. Zynektic

    Zynektic Well-Known Member

    I was just on about the area you add a Moderator, you can tick permissions there and also on the usergroup permissions, whether either of them made a difference if one is checked and the other is not set to allow but if Jeremy was replying to me then I guess not.
     
  7. RichardKYA

    RichardKYA Well-Known Member

    Oh OK, I haven't added them as a moderator anywhere, they are a super mod, but I was going to break down the "Manage (move, merge, etc.) thread by anyone:" permissions because I don't like them all being clumped together. Some mods I want to be able to move threads, but others not, same goes for editing threads by anyone, merging threads, etc. Anyway, as I was about to start breaking these down, I noticed that "Moderator Actions" remains in the tools, even though they can't use it, but they still have all the other moderator permissions apart from "Manage (move, merge, etc.) thread by anyone:".
     
  8. Jeremy

    Jeremy XenForo Moderator Staff Member

    I was replying that there isn't a moderator permission to show that link. It depends on $canViewModeratorLogs, but I would need to look up the code for that, of which, I cannot do on my phone.
     
  9. Mike

    Mike XenForo Developer Staff Member

    There's an inconsistency in the permission check here. The link is based on the result of
    canViewThreadModeratorLog() which checks for one of a bunch of permissions. The actual action only checks (roughly) one of those.
     
    Jeremy likes this.
  10. RichardKYA

    RichardKYA Well-Known Member

    Can this be reproduced on your installation or is it something that seems isolated to mine?

    **EDIT** I've just seen it's been moved to Bug Reports, so that answers my above question.
     
  11. imthebest

    imthebest Formerly Super120

    Sorry I didn't catch you.

    Actually what permission controls the ability for moderators to see the Moderator Actions link?
     
  12. RichardKYA

    RichardKYA Well-Known Member

    I think what he is saying is that it checks a bunch of permissions and that there isn't actually any "one" permission that allows the link to viewable, but the actual action of viewing the moderators actions themselves, only checks one permission and this is what is causing the inconsistency.
     
    imthebest likes this.
  13. Chris D

    Chris D XenForo Developer Staff Member

    These ones specifically in case you're interested:

    upload_2015-6-11_21-50-56.png
     
    imthebest likes this.
  14. Chris D

    Chris D XenForo Developer Staff Member

    This is fixed now, thanks.
     
    RichardKYA likes this.
  15. imthebest

    imthebest Formerly Super120

    So now what specific permission controls the display of the "Moderator Actions"?
     
  16. Chris D

    Chris D XenForo Developer Staff Member

  17. imthebest

    imthebest Formerly Super120

    So now a moderator needs to have all those 6 permissions enabled otherwise he is not going to be able to see the moderator actions?
     
  18. Chris D

    Chris D XenForo Developer Staff Member

    No. They need to have any one of those permissions.
     
    imthebest likes this.

Share This Page