• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed  missing square brackets result in antivirus warning

Panupat

Well-known member
#1
This happened to one of the threads in my forum. Xenforo 1.0.4. No add on.

The post looks like this

Code:
[media=youtube]YbSrw5zHBKE[/media]
[media=youtube]H0cpai31_6s[/media
[media=youtube]juw8hWiBrts[/media]

(some thai texts)

ลองเข้าไปอ่านในนี้ดูค่ะ http://ononeanimation.com/board/threads/50/

[/media]
On the second line, there's 1 missing square brackets.
On the last line, there's extra [/media ]

All machines at my office has NOD 32 installed, and they all reported some trojan while this page is loading, before it timed out.

Removing the extra [/media ] doesn't do anything.

But adding the missing ], and all the errors go away.
 

Mike

XenForo developer
Staff member
#2
That is certainly a false positive from the AV software.

Regardless, there's no reason to allow line breaks in media identifiers, so now if it finds one, it will skip the media. The post still wouldn't display correctly obviously, but it shouldn't try to create a meaningless embed.