1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Missing + in admin phrase

Discussion in 'Resolved Bug Reports' started by Luxus, Apr 15, 2013.

  1. Luxus

    Luxus Well-Known Member

    I let the image speak :)
    createbuttons.png

    Edit: Actually the phrase is ok, but the + is missing from the html.
     
  2. Allan

    Allan Well-Known Member

    Where is ?
     
  3. Luxus

    Luxus Well-Known Member

    I mean it's missing from the button html.

    buttons.png

    The + isn't part of any phrase. It comes from somewhere else.
     
  4. Mike

    Mike XenForo Developer Staff Member

    What page is that on though?

    Though I think there is an issue on the admin page not having the plus, there is no page that combines all of those buttons like that.
     
  5. Luxus

    Luxus Well-Known Member

    It's in admin.php?admins/. I have combined all those buttons with firebug for your convenience :)
     
    Shelley likes this.
  6. Luxus

    Luxus Well-Known Member

    So the plus is hardcoded in the html. This is the html of the 'Create New Moderator Button':
    Code:
    <xen:topctrl>
    	<a href="{xen:adminlink 'moderators/add'}" class="button">+ {xen:phrase create_new_moderator}</a>
    </xen:topctrl>
    And this is the html of the 'Create New Administrator Button' from the admin_list template:
    Code:
    <xen:topctrl>
    	<a href="{xen:adminlink 'admins/add'}" class="button">{xen:phrase create_new_administrator}</a>
    </xen:topctrl>
    As you can see there is a + missing.
     
    CyberAP likes this.
  7. Jeremy

    Jeremy XenForo Moderator Staff Member

    Coming from a developer stand point, it's always better to only put necessary information into bug reports, such as template and an image of it actually occurring with the description. Modifying content for an image has developers looking for it happening in that situation, often to be regarded as user error or a bad add-on. (y)
     
    CyberAP, Lycaon, Luxus and 1 other person like this.
  8. Luxus

    Luxus Well-Known Member

    Oh, I'm sorry Mike if I have wasted your time :(
     
  9. Alien

    Alien Well-Known Member

    You haven't wasted anyone's time, KK was just referring to keeping the screenshots unmodified for the developers...
     
    Jeremy likes this.
  10. Jeremy

    Jeremy XenForo Moderator Staff Member

    You still posted a valid bug report, just modified the circumstances in which you posted it. This causes debugging to take longer as we can't replicate what you show us as having an issue. I work on client projects where some of the bug reports are horrendous with unrelated information and I spend more time deciphering what the bug is versus actually fixing the bug.
     
  11. Luxus

    Luxus Well-Known Member

    Yeah, I will make sure to include more information if I modify something next time.
     
    Jeremy likes this.
  12. Mike

    Mike XenForo Developer Staff Member

    Sorted.
     

Share This Page