Link Checker by AddonsLab [Paid] 1.17.0
- Thread starter AddonsLab
- Start date
Nirjonadda
Well-known member
@AddonsLab Please move Moderate Dead Links Permissions in under Link Checker without mixing in Forum Moderator Permissions? Add User Group Permissions setting are Seperate? Not mixing with xF core Group Permissions. If mixing xF core Group Permissions, we have a lot of user group and Its not easy making set to Group Permissions. One more bug, Delete the index before rebuilding are not working. I do Rebuild Index Links with Delete the index before rebuilding but still are not removed/updated Check Dead Links info and Same are old info.
Last edited:
AddonsLab
Well-known member
If enabled, the product will not re-check the URL if it was checked within last 24 hours. This is the desired behavior in most of cases, but if you have any specific cases, which have wrong status, you can find the link using the search controls (filtering by status, domain etc.) and check them disabling the cache. In this case you can be sure, that the system will re-send the request to the remote server and try to validate the link again.
Thank you for the report. This is reproduced and fixed. We will release the fix now.
The permission is not just a usual user permission, it is forum moderator permission. You can not give this permission to all your users/usergroups, but only your moderators, as only moderators can see the Moderator bar, and the permission can be set on per-node basis as well (usual permissions are set only per usergroup, not per node). If you are not sure what I mean, please consider checking XenForo documentation about moderators and forum-based moderation permissions - https://xenforo.com/help/moderators/
This is not a bug but the intended behavior. Link Index and Link Status are different entities in the product. Link index updates the list of all found links in posts. It does not check, if the link is valid or no, it just finds the links and adds them Manage Links page. So, you need to rebuild the index with deleting the existing index only when you do large changes in your database (e.g. use a tool that removed many posts or entire forums, and the links from these posts are still listed in Manage Links page). You can run rebuilding the index also when you run an importer that creates new posts to detect the links in these posts (no need to remove the existing link in this case, however).
Link statuses do not get deleted when you delete the index, as in many cases admins need to "find" the links in the posts, but there is no need to run the check agains remote servers. And if you want to update link statuses, simply run the check for Dead Links and disabled the local cache. If you do not enable any filters, it will check all URLs and will validate them all one more time. By the way, there is no need to run this, the remote check itself works as in the version before, so it is not going to check your links "better" and give some better results, it is just going to re-check all links.
Thank you!
Nirjonadda
Well-known member
Yes I do understand but why are not this permission in under Link Checker group, Why are not added seperate without mixing in xF moderated permission? It impossible to understand that permission option come from link checker add-on. Many other add-on moderators permission come are separated without adding xF core permission. Please make under consideration for improvements.
AddonsLab
Well-known member
Thank you for the suggestion one more time, but we can't implement this in the add-on, as we don't find it correct. Please check the add-ons you are referring to, and you will understand, that they put "Forum Moderator Permissions" with XenForo forum moderator permissions. The other "moderator" permissions, that those add-ons have are not forum-specific (who can do what in which forum), they are add-on specific (who can moderate articles, who can delete article comments etc., so, nothing based on a "forum"). Please see the screenshot with some add-on permissions in the same group as Dead Link check moderator permission. I hope this clarifies it fully now.
Thank you!
AddonsLab
Well-known member
AddonsLab updated Link Checker by AddonsLab with a new update entry:
Bug fix: delete link from Admin Panel does not work from
Read the rest of this update entry...
Bug fix: delete link from Admin Panel does not work from
Read the rest of this update entry...
Nirjonadda
Well-known member
Then you are not like improve this add-on? Like to coding easy way? Then why this add-on moderators permission are not added in "Forum Moderator Permissions" ? Lot of coders like adding in "Forum Moderator Permissions" because need to writing lot of code for separated?
AddonsLab
Well-known member
I am sorry to hear your consideration of us not wanting to write "more code". We spent 20 days fully working on this add-on to make some features possible, which we didn't have to, but we did our best, and this was a large improvement for the add-on, so now it is quite unexpected and disappointing to get such feedback and accusation of us being lazy to improve the add-on. And believe me, the amount of code written for that is 1000s of times more than needed to move one permission to another place in the list (it is 5 minutes change actually).
Please read my previous message in details, and try to understand the part about per-forum permissions. The add-on you linked does not have per-forum permissions, at least checking the screenshots. And the other two add-ons you can see in my screenshot are one of best selling add-ons on XenForo.com and I am sure their authors didn't put the permissions there because they were lazy to write a bit of more code.
I am not sure how long you are using XenForo and how good you understand the system, I am personally working on XenForo from the first day it was released, didn't just seen some the add-ons installed, but implemented hundreds of features and enhancements to many of them for private customers, checking and understand every bit of code of that add-ons. So, whatever information we share with you here is well-though and confirmed with years of experience, so please try to understand it in all details instead of just replying back and just forcing your opinion.
We always appreciate bug-fix reports and improvement suggestions. From you alone, we got many bug reports and fixed them all. You have also suggested changes that were approved and implemented. So, whenever we decide not to implement a change, it is based on our knowledge of XenForo, the functionality of our add-on and the add-ons in general. Our decision in this regard is final.
Thank you for understanding and support.
Just let us know if you have any questions.
Thank you!
Nirjonadda
Well-known member
I am added my own opinion because this add-on moderators and user permission are not same group and I spend one hour to find out moderation queue permission. Some are USA and some are UK location. Then How we can know that what permission come from link check add-on? If are not added all in same place? Anyway thanks for your great improvements for this add-on functionality. Hopefully more improvements in next updates .... 
Last edited:
AddonsLab
Well-known member
I am added my own opinion because this add-on moderators and user permission are not same group and I spend one hour to find out moderation queue permission. Some are USA and some are UK location. Then How we can know that what permission come from link check add-on? If are not added all in same place? Anyway thanks for your great improvements for this add-on functionality. Hopefully more improvements in next updates ....
Thank you for the reply. I understand your reasons to have permissions associated with an add-on in one place, but sometimes there are other reasons not to have them in one place and this is one of that cases.
In this release, we included practically all improvements and new features we are planning for this add-on. Further releases will be only bug-fixes and performance improvements to improve add-on stability and prepare for XenForo 2.x release.
Thank you!
got this error when using the cron job for checking dead links:
Code:
Zend_Uri_Exception: Invalid URI supplied - library/Zend/Uri/Http.php:156
Gegenereerd Door: Onbekend Account, Vandaag om 05:21
Stack Trace
#0 /home/bodyforum/public_html/library/Zend/Uri.php(143): Zend_Uri_Http->__construct('http', '//www.dutchbody...')
#1 /home/bodyforum/public_html/library/Zend/Http/Client.php(270): Zend_Uri::factory('http://www.dutc...')
#2 /home/bodyforum/public_html/library/Zend/Http/Client.php(253): Zend_Http_Client->setUri('http://www.dutc...')
#3 /home/bodyforum/public_html/library/XenForo/Helper/Http.php(34): Zend_Http_Client->__construct('http://www.dutc...', Array)
#4 /home/bodyforum/public_html/library/AddonsLab/Core/Service/Xf1HttpClient.php(101): XenForo_Helper_Http::getClient('http://www.dutc...', Array)
#5 /home/bodyforum/public_html/library/AddonsLab/LinkChecker/Library/Service/TagUrlValidator.php(85): AddonsLab\Core\Service\Xf1HttpClient->getClient()
#6 /home/bodyforum/public_html/library/AddonsLab/LinkChecker/Library/Service/TagProvider.php(217): AddonsLab\LinkChecker\Library\Service\TagUrlValidator->checkTagUrlMapping(Object(AddonsLab\LinkChecker\Library\Mapping\TagUrlMapping))
#7 /home/bodyforum/public_html/library/AddonsLab/LinkChecker/Deferred/DeadLink.php(107): AddonsLab\LinkChecker\Library\Service\TagProvider->validateTagUrlMapping(Object(AddonsLab\LinkChecker\Library\Mapping\TagUrlMapping), '1', '1')
#8 /home/bodyforum/public_html/library/XenForo/Model/Deferred.php(295): AddonsLab_LinkChecker_Deferred_DeadLink->execute(Array, Array, 7.99999904633, '')
#9 /home/bodyforum/public_html/library/XenForo/Model/Deferred.php(429): XenForo_Model_Deferred->runDeferred(Array, 7.99999904633, '', false)
#10 /home/bodyforum/public_html/library/XenForo/Model/Deferred.php(374): XenForo_Model_Deferred->_runInternal(Array, NULL, '', false)
#11 /home/bodyforum/public_html/deferred.php(23): XenForo_Model_Deferred->run(false)
#12 {main}
Aanvraagstatus
array(3) {
["url"] => string(42) "https://forum.bodybuilding.nl/" deferred php
["_GET"] => array(0) {
}
["_POST"] => array(3) {
["_xfRequestUri"] => string(57) "/topics/help-mij-probolan-50-een-droom-of-een-hel.382107/"
["_xfNoRedirect"] => string(1) "1"
["_xfResponseType"] => string(4) "json"
}
}
Last edited:
And this when deleting link (limit number):
Code:
Mysqli statement execute error : Lock wait timeout exceeded; try restarting transaction
[LIST=1]
[*]Zend_Db_Statement_Mysqli->_execute() in Zend/Db/Statement.php at line 297
[*]Zend_Db_Statement->execute() in Zend/Db/Adapter/Abstract.php at line 479
[*]Zend_Db_Adapter_Abstract->query() in Zend/Db/Adapter/Abstract.php at line 661
[*]Zend_Db_Adapter_Abstract->delete() in XenForo/DataWriter.php at line 1839
[*]XenForo_DataWriter->_delete() in XenForo/DataWriter.php at line 1792
[*]XenForo_DataWriter->delete() in AddonsLab/LinkChecker/DataProvider/TagDataProvider.php at line 91
[*]AddonsLab\LinkChecker\DataProvider\TagDataProvider->deleteTag() in AddonsLab/LinkChecker/Library/Service/TagProvider.php at line 74
[*]AddonsLab\LinkChecker\Library\Service\TagProvider->deleteTagList() in AddonsLab/LinkChecker/Library/Service/MessageUpdater.php at line 74
[*]AddonsLab\LinkChecker\Library\Service\MessageUpdater->processContent() in AddonsLab/LinkChecker/Extend/XenForo/DataWriter/DiscussionMessage/Post.phpat line 41
[*]AddonsLab_LinkChecker_Extend_XenForo_DataWriter_DiscussionMessage_Post->_postSaveAfterTransaction() inXFLiam/ImpersonateUser/Extend/XenForo/DataWriter/DiscussionMessage/Post.php at line 25
[*]XFLiam_ImpersonateUser_Extend_XenForo_DataWriter_DiscussionMessage_Post->_postSaveAfterTransaction() in XenForo/DataWriter.php at line 1437
[*]XenForo_DataWriter->save() in DigitalPointSpy/DataWriter/DiscussionMessage/Post.php at line 7
[*]DigitalPointSpy_DataWriter_DiscussionMessage_Post->save() in AddonsLab/ContentHandler/Traits/PostTrait.php at line 260
[*]AddonsLab_LinkChecker_ContentHandler_PostHandler->updateContentMessage() in AddonsLab/LinkChecker/Library/Content.php at line 90
[*]AddonsLab\LinkChecker\Library\Content->persist() in AddonsLab/LinkChecker/Library/Service/TagReplacementProcessor.php at line 242
[*]AddonsLab\LinkChecker\Library\Service\TagReplacementProcessor->persistTagReplacementsForContent() inAddonsLab/LinkChecker/Library/Service/TagReplacementProcessor.php at line 292
[*]AddonsLab\LinkChecker\Library\Service\TagReplacementProcessor->persistTagReplacementList() in AddonsLab/LinkChecker/Deferred/BatchUpdate.php at line 86
[*]AddonsLab_LinkChecker_Deferred_BatchUpdate->execute() in XenForo/Model/Deferred.php at line 295
[*]XenForo_Model_Deferred->runDeferred() in XenForo/Model/Deferred.php at line 429
[*]XenForo_Model_Deferred->_runInternal() in XenForo/Model/Deferred.php at line 374
[*]XenForo_Model_Deferred->run() in XenForo/ControllerAdmin/Tools.php at line 159
[*]XenForo_ControllerAdmin_Tools->actionRunDeferred() in XenForo/FrontController.php at line 351
[*]XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 134
[*]XenForo_FrontController->run() in /home/bodyforum/public_html/admin.php at line 13
[/LIST]AddonsLab
Well-known member
Hello, @dutchbb !
In the first case, it seems the error is due to some malformed URL. We will update the product to make sure the product handles such cases properly and does not throw any errors.
The second error means, that the row which the product tried to update in the database was being read or written to exactly at that moment. I guess this error should be episodical, and if you try to delete it again, it should work. But anyway, we will check this in details and see if there is any other cause of this issue and make sure prevent it.
We will update here with the solution soon.
Thank you!
In the first case, it seems the error is due to some malformed URL. We will update the product to make sure the product handles such cases properly and does not throw any errors.
The second error means, that the row which the product tried to update in the database was being read or written to exactly at that moment. I guess this error should be episodical, and if you try to delete it again, it should work. But anyway, we will check this in details and see if there is any other cause of this issue and make sure prevent it.
We will update here with the solution soon.
Thank you!
Tested and i can't get in batch update, this gives the notice that there is a batch process waiting. Resuming that process gives same error. I removed the task form xf_defered and tried again, this gives same error but only when using ->processing configuration -> limit number
Nirjonadda
Well-known member
@AddonsLab How many time take for Dead Link check? Over 24 Hours is running .... Its doing very slowly ?
AddonsLab
Well-known member
Link checking performance depends mostly on the speed of remote sites, and not the product itself, and unfortunately, there is not much we can do about it. If you have put timeout value too much high (e.g. 5 seconds), every link that times out makes the script to wait for 5 seconds before it will go on checking the next link. Some links may be faster, some slower, but the overall speed of your check is 31941 in 24 hours, which is about 2.7 seconds per link. Another user contacted us in our Support system with speed of checks of links about 1second/per link (about 21k links in 6 hours). So the speed of check depends on types of links and sites you are linking too. On your board, you may have many links all to the same domain, which is responding a bit slowly, causing the overall speed of process to decrease.
We are working on this part further now, to allow admins to cancel the process manually. You can cancel the check and check only the links you are interested in (as mentioned before, there is no need to re-check all links after the upgrade).
Thank you!
AddonsLab
Well-known member
AddonsLab updated Link Checker by AddonsLab with a new update entry:
Stability fixes for invalid URLs and cron task cancellation
Read the rest of this update entry...
Stability fixes for invalid URLs and cron task cancellation
Read the rest of this update entry...
Nirjonadda
Well-known member
@AddonsLab What "Cancel" button you are added in 1.7.2 ? I have still "Cancel" button in version 1.7.0 , So we need use "Cancel" button in version 1.7.0 for 1.7.2 update? What does two different "Cancel" button?
AddonsLab
Well-known member
@AddonsLab What "Cancel" button you are added in 1.7.2 ? I have still "Cancel" button in version 1.7.0 , So we need use "Cancel" button in version 1.7.0 for 1.7.2 update? What does two different "Cancel" button?
The button is added for background tasks when running the check via a cron jobs. Your screenshot shows the deferred task in the browser, which is provided by XenForo.
Here is a screenshot how the button looks in the new version:
By the way, we have just applied a small fix and re-uploaded the package, so if you have already downloaded the package, please download it again and re-upload the files. Please note, that you may get PHP errors if upgrading while the link check in progress.
Thank you!
