1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Like Listings Overlay Broken (Media and Albums Likes Summary)

Discussion in 'Media Gallery Resolved Bugs' started by Amaury, Nov 12, 2014.

  1. Amaury

    Amaury Well-Known Member

    If I like a media item that already has at least three likes and click on "X other person / others," the like listings overlay appears broken:

    upload_2014-11-12_9-37-1.png

    I have to refresh the page to rectify the issue.
     
    Last edited: Nov 12, 2014
  2. Brogan

    Brogan XenForo Moderator Staff Member

    Which browser?

    Looks OK to me in Chrome.

    upload_2014-11-12_17-43-13.png
     
    Chris D likes this.
  3. Chris D

    Chris D XenForo Developer Staff Member

    I can't reproduce this at the moment.

    Can you reproduce it every time? Any particular steps?
     
  4. Amaury

    Amaury Well-Known Member

  5. Brogan

    Brogan XenForo Moderator Staff Member

    OK for me in FF 33.1 too.
     
  6. Amaury

    Amaury Well-Known Member

    Yes.

    As for the steps:
    1. Go to a media item that has at least three likes
    2. Like the item
    3. It'll appear as "You, A, B, and 1 other person / X others like this"
    4. Click on "1 other person / X others like this"
    5. The overlay appears broken

    If you already liked an item, clicking unlike will result in the same issue.

    Refreshing the page makes it appear correctly.
     
  7. Chris D

    Chris D XenForo Developer Staff Member

    We just realised how to reproduce this.

    It is fixed now, thanks.

    The changes will be rolled out here in the future.
     
    Amaury likes this.
  8. Amaury

    Amaury Well-Known Member

    Yeah, sorry. I thought the refreshing statement at the end of my OP implied that. However, I should have clarified.

    (y)
     
  9. Chris D

    Chris D XenForo Developer Staff Member

    It applies to the likes summary on albums too, so that has also been fixed.
     
    Amaury likes this.
  10. Amaury

    Amaury Well-Known Member

    Just out of curiosity, what was the issue?
     
  11. Chris D

    Chris D XenForo Developer Staff Member

    The URL used on the likes_summary template should have been defined as 'xengallery/likes' or for albums 'xengallery/albums/likes' but, the 'likes' part was missing, hence the likes_summary link actually pointed back at the content; hence why in your screenshot you saw the media item try to load again in an overlay rather than the actual likes summary.
     
    Amaury likes this.
  12. Amaury

    Amaury Well-Known Member

    Ah, I see. So how did refreshing the page make it appear properly?
     
  13. Chris D

    Chris D XenForo Developer Staff Member

    It specifically relates to the AJAX action that updates the content of the page. That action was replacing the correct link with the incorrect link.
     
    Amaury likes this.
  14. Amaury

    Amaury Well-Known Member

    Only your first day and your support is already outstanding. Of course, it always has been. :)
     
  15. Jeremy

    Jeremy XenForo Moderator Staff Member

    It isn't his first day, but did you expect anything else?
     
  16. Amaury

    Amaury Well-Known Member

    Well, first day on the team?

    But no, of course not. :)
     

Share This Page