Fixed Like Listings Overlay Broken (Media and Albums Likes Summary)

[Amaury]

If I like a media item that already has at least three likes and click on "X other person / others," the like listings overlay appears broken:



I have to refresh the page to rectify the issue.

 

[Paul B]

Which browser?

Looks OK to me in Chrome.

 

[Chris D]

I can't reproduce this at the moment.

Can you reproduce it every time? Any particular steps?

 

[Amaury]

Which browser?

Looks OK to me in Chrome.

View attachment 88903

Firefox 33.1.

 

[Paul B]

OK for me in FF 33.1 too.

 

[Amaury]

Can you reproduce it every time? Any particular steps?

Yes.

As for the steps:

1. Go to a media item that has at least three likes
2. Like the item
3. It'll appear as "You, A, B, and 1 other person / X others like this"
4. Click on "1 other person / X others like this"
5. The overlay appears broken

If you already liked an item, clicking unlike will result in the same issue.

Refreshing the page makes it appear correctly.

 

[Chris D]

We just realised how to reproduce this.

It is fixed now, thanks.

The changes will be rolled out here in the future.

 

[Amaury]

We just realised how to reproduce this.

Yeah, sorry. I thought the refreshing statement at the end of my OP implied that. However, I should have clarified.

It is fixed now, thanks.

The changes will be rolled out here in the future.

 

[Chris D]

It applies to the likes summary on albums too, so that has also been fixed.

 

[Amaury]

It applies to the likes summary on albums too, so that has also been fixed.

Just out of curiosity, what was the issue?

 

[Chris D]

The URL used on the likes_summary template should have been defined as 'xengallery/likes' or for albums 'xengallery/albums/likes' but, the 'likes' part was missing, hence the likes_summary link actually pointed back at the content; hence why in your screenshot you saw the media item try to load again in an overlay rather than the actual likes summary.

 

[Amaury]

The URL used on the likes_summary template should have been defined as 'xengallery/likes' or for albums 'xengallery/albums/likes' but, the 'likes' part was missing, hence the likes_summary link actually pointed back at the content; hence why in your screenshot you saw the media item try to load again in an overlay rather than the actual likes summary.

Ah, I see. So how did refreshing the page make it appear properly?

 

[Chris D]

It specifically relates to the AJAX action that updates the content of the page. That action was replacing the correct link with the incorrect link.

 

[Amaury]

It specifically relates to the AJAX action that updates the content of the page. That action was replacing the correct link with the incorrect link.

Only your first day and your support is already outstanding. Of course, it always has been.

 

[Jeremy]

It isn't his first day, but did you expect anything else?

 

[Amaury]

It isn't his first day, but did you expect anything else?

Well, first day on the team?

But no, of course not.