[Liam W] (RIP) Member Self Delete

[Liam W] (RIP) Member Self Delete 2.0.5 Patch Level 7

No permission to download
Quick workaround fix for the above problem. Edit "src\addons\LiamW\AccountDelete\XF\Admin\Controller\Log.php", replace line 31:
Code:
        return $this->view('Log\AccountDeletion', 'liamw_accountdelete_user_delete_log', $viewParams);
With:
Code:
        return $this->view('Log\AccountDeletion:View', 'liamw_accountdelete_user_delete_log', $viewParams);
Basically just adding ":View" there.
Of course if you manually edit this on your site, the hash for that file is changed and your install will report unexpected contents for the addon.
Thanks, I had the same problem with 2.2.15 with patch 2 applied, and with this, I have solved it ;)
 
I am running this with 2.3 and I don't appear to have any problems with the above fix applied.

However, I am getting the "There are files with unexpected contents" warning (obviously).
 
Just installed this add-on to test(XF 2.3). When changing options, I get the following error:
TypeError: XF\Job\Manager::enqueueLater(): Argument #2 ($runTime) must be of type int, null given, called in /websir/src/addons/LiamW/AccountDelete/Listener.php on line 78 in src/XF/Job/Manager.php at line 524
  1. XF\Job\Manager->enqueueLater() in src/addons/LiamW/AccountDelete/Listener.php at line 78
  2. LiamW\AccountDelete\Listener::LiamW\AccountDelete\{closure}() in src/XF.php at line 653
  3. XF::triggerRunOnce() in src/XF/Mvc/Dispatcher.php at line 164
  4. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
  5. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
  6. XF\App->run() in src/XF.php at line 806
  7. XF::runApp() in admin.php at line 15

    Stack trace

    #0 src/addons/LiamW/AccountDelete/Listener.php(94): XF\Job\Manager->enqueueLater('lwAccountDelete...', NULL, 'LiamW\\AccountDe...')
    #1 src/XF.php(653): LiamW\AccountDelete\Listener::LiamW\AccountDelete\{closure}()
    #2 [internal function]: XF::triggerRunOnce()
    #3 {main}

    Request State

    array(4) {
    ["url"] => string(25) "/admin.php?options/update"
    ["referrer"] => string(74) "https://domain.tld/admin.php?options/groups/liamw_memberselfdelete/"
    ["_GET"] => array(1) {
    ["options/update"] => string(0) ""
    }
    ["_POST"] => array(6) {
    ["_xfToken"] => string(8) "********"
    ["options_listed"] => array(13) {
    [0] => string(33) "liamw_accountdelete_user_criteria"
    [1] => string(34) "liamw_accountdelete_deletion_delay"
    [2] => string(38) "liamw_accountdelete_reminder_threshold"
    [3] => string(32) "liamw_accountdelete_repeat_delay"
    [4] => string(35) "liamw_accountdelete_deletion_method"
    [5] => string(38) "liamw_accountdelete_randomise_username"
    [6] => string(26) "liamw_accountdelete_reason"
    [7] => string(35) "liamw_accountdelete_reasonMaxLength"
    [8] => string(39) "liamw_accountdelete_visitor_menu_button"
    [9] => string(32) "liamw_accountdelete_thread_forum"
    [10] => string(31) "liamw_accountdelete_thread_user"
    [11] => string(32) "liamw_accountdelete_thread_title"
    [12] => string(34) "liamw_accountdelete_thread_message"
    }
    ["options"] => array(12) {
    ["liamw_accountdelete_deletion_delay"] => string(1) "7"
    ["liamw_accountdelete_reminder_threshold"] => string(1) "3"
    ["liamw_accountdelete_repeat_delay"] => string(1) "0"
    ["liamw_accountdelete_deletion_method"] => array(2) {
    ["mode"] => string(6) "delete"
    ["delete_options"] => array(1) {
    ["ban_email"] => string(1) "1"
    }
    }
    ["liamw_accountdelete_randomise_username"] => array(2) {
    ["enabled"] => string(1) "1"
    ["username"] => string(19) "Anonymous {userId}"
    }
    ["liamw_accountdelete_reason"] => array(2) {
    ["request"] => string(1) "1"
    ["require"] => string(1) "1"
    }
    ["liamw_accountdelete_reasonMaxLength"] => string(5) "10000"
    ["liamw_accountdelete_visitor_menu_button"] => string(1) "1"
    ["liamw_accountdelete_thread_forum"] => string(2) "331"
    ["liamw_accountdelete_thread_user"] => string(7) "User"
    ["liamw_accountdelete_thread_title"] => string(31) "Delete account: {username}"
    ["liamw_accountdelete_thread_message"] => string(125) "{username} bla bla
    Reden: {reason}
    Einddatum: {end_date}"
    }
    ["_xfResponseType"] => string(4) "json"
    ["_xfWithData"] => string(1) "1"
    ["_xfRequestUri"] => string(49) "/admin.php?options/groups/liamw_memberselfdelete/"
    }
    }


Also, when I try to enable some User Cirteria (like "User is logged in") and click save,the page reverts to the General Options tab and nothing has been saved.
 
Last edited:
Just installed this on 2.3.4 and I am unable to save selections in user criteria.

If I make a selection (like Member is logged in) and click save, the selection is not saved.

Any ideas?

Thanks!
 
I dont know if this was fixed. But i dont think so.
@Ozzy47 @Painbaker a bug we found with this addon is, if you ban a user temporarily trough a warn and they start the deletion of their account and then stop it the user is unbanned.
Can't reproduce this on a clean XF 2.3.4 and 2.2.16 PL 2 setup.

Banned user should not be able to access these pages, and in addition canceling account deletion does not change the is_banned column. Unless you have an addon that changes this behavior or the logic of banning users.
 
Can't reproduce this on a clean XF 2.3.4 and 2.2.16 PL 2 setup.

Banned user should not be able to access these pages, and in addition canceling account deletion does not change the is_banned column. Unless you have an addon that changes this behavior or the logic of banning users.

I'll check and try, and reach you in PM if the bug still occurres.
 
Just installed this add-on to test(XF 2.3). When changing options, I get the following error:


Also, when I try to enable some User Cirteria (like "User is logged in") and click save,the page reverts to the General Options tab and nothing has been saved.

This error is happening still, just tested on XF 2.3.4 and received an error. As he mentioned, it is triggered when you change options and try to Save on the options page for the addon.
Code:
TypeError: XF\Job\Manager::enqueueLater(): Argument #2 ($runTime) must be of type int, null given, called in /websites/site-test/src/addons/LiamW/AccountDelete/Listener.php on line 81 in src/XF/Job/Manager.php at line 524

    XF\Job\Manager->enqueueLater() in src/addons/LiamW/AccountDelete/Listener.php at line 81
    LiamW\AccountDelete\Listener::LiamW\AccountDelete\{closure}() in src/XF.php at line 653
    XF::triggerRunOnce() in src/XF/Mvc/Dispatcher.php at line 164
    XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
    XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
    XF\App->run() in src/XF.php at line 806
    XF::runApp() in admin.php at line 15
Surprisingly though, the couple of minor option changes I made seemed to be properly saved, and the error wasn't even saved to the admin error log for later reference. The error is easily and consistently repeatable though.
And further testing based on the above reports, I can confirm that any changes to the further criteria pages in Options are not properly saved. Which is odd, in that changing things on those pages don't trigger an error when you click Save, but don't in fact save your changes, where any changes you make on the main first Options page are properly saved but do trigger that error message.
@Painbaker
 
Back
Top Bottom