Hey Xon great addon from you as usual. Thank you for making it free. It works well on Chome and Firefox. Just noticed in Safari mobile, the images disappear. Is there any extra setting I need to do to make it work?
I'll look into making this disablable for mobile devices.i get following error while installing this addon
Line 33: Template tags are not well formed. Tag macro was found when expecting if.
Also i see settings imported for this addon in option.
- Upgrade lazysizes from v4.0.1 to v4.0.2
@Xon Some user reported that image are not loading in mobile browser or windows. Also I am getting image are very slow loading in mobile browser. Please do you have image loading improvement update for mobile browser and windows? Also can be add option disable Lazy Load for mobile browser?
Line 33: Template tags are not well formed. Tag macro was found when expecting if.
If I try to update I have this error:
Edit:
ok, I had to disable [xenMade.com] SEO (SEO2) to update Lazy Load
I'm not sure, updating the lazy load script might help, otherwise I'll need to add a toggle for disabling when a mobile browser is detected.@Xon does fixed this issue? Image are not loading in mobile browser or windows browser for some user?
I don't have a copy of @au lait's SEO (SEO2). This add-on is open-source, and I accept pull-requests on github for fixes.If I try to update I have this error:
Edit:
ok, I had to disable [xenMade.com] SEO (SEO2) to update Lazy Load
The error occurs because this add-on and the SEO add-on want to change exactly the same area...If I try to update I have this error:
Edit:
ok, I had to disable [xenMade.com] SEO (SEO2) to update Lazy Load
hmmm... I don't have any other errors with this @Xon's addonAlthough I have now deactivated all add-ons, this add-on still does not work.
View attachment 174995
View attachment 174996
Server error logs
Template error: Macro public:lightbox_macros:setup is unknown
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
Template error: Macro public:lightbox_macros:single_image is unknown
- 59 minutes ago
- src/XF/Template/Templater.php:556
- 59 minutes ago
- src/XF/Template/Templater.php:556
Showing all items
Server error log
Stack trace
- ErrorException: Template error: Macro public:lightbox_macros:setup is unknown
- src/XF/Template/Templater.php:556
- Generated by: Unknown account
- 15.05.2018 o 09:16
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Macro public:li...', 'src/XF/Tem...', 556, Array)
#1 src/XF/Template/Templater.php(556): trigger_error('Macro public:li...', 512)
#2 src/XF/Template/Templater.php(660): XF\Template\Templater->getTemplateMacro('public', 'lightbox_macros', 'setup')
#3 internal_data/code_cache/templates/l3/s11/public/thread_view.php(321): XF\Template\Templater->callMacro('lightbox_macros', 'setup', Array, Array)
#4 src/XF/Template/Templater.php(1248): XF\Template\Templater->{closure}(Object(KL\UserImprovements\Template\Templater), Array)
#5 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#6 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#7 src/XF/Mvc/Dispatcher.php(332): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#8 src/XF/Mvc/Dispatcher.php(303): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(44): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#10 src/XF/App.php(1891): XF\Mvc\Dispatcher->run()
#11 src/XF.php(328): XF\App->run()
#12 index.php(13): XF::runApp('XF\\Pub\\App')
#13 {main}
Request state
array(4) {
["url"] => string(18) "/t/wyborcza.23143/"
["referrer"] => bool(false)
["_GET"] => array(1) {
["/t/wyborcza_23143/"] => string(0) ""
}
["_POST"] => array(0) {
}
}
- Upgrade lazysizes from v4.0.2 to v4.1.4
I think it is a compatibility glitch with the lazyloader software interacting with XF2's javascript. Can you see if the v2.0.4 release works? Otherwise I'll just mark this add-on as only supporting newer than Chome 59.This addon don't load images in browsers with chrome 59 and lower, its weird because xf1 version works fine everywhere.
Do you know why @Xon?
I think it is a compatibility glitch with the lazyloader software interacting with XF2's javascript. Can you see if the v2.0.4 release works? Otherwise I'll just mark this add-on as only supporting newer than Chome 59.
Did this with some tweaks, and my pages with youtube embeds load 68% fasterhope on future this add-on support video too especially for youtube embed
https://webdesign.tutsplus.com/tutorials/how-to-lazy-load-embedded-youtube-videos--cms-26743
We use essential cookies to make this site work, and optional cookies to enhance your experience.