Latest Threads Monthly Email [Deleted]

[Code Monkey]

I see it does. Never mind then.

 

[The Sandman]

Is there an issue with this addon with XF 1.2.1? I'm suddenly getting this error when the cron tries to run:

Parse error: syntax error, unexpected T_FUNCTION in /home/adminx/public_html/library/XenForo/Mail.php on line 362

Update! It was the XF 1.2.1 "Mail bug" (an issue with PHP 5.2) - fixed with this patch: http://xenforo.com/community/threads/xenforo-1-2-1-released.58022/#post-618539 and now working.

 

[Adam Howard]

Feature request:

Would love to see an option to select which forums are or are not included.

Please & thank you in advance.

 

[eagle eyes]

To manually specify forum IDs to pull from:

Open library/MonthlyEmails/Model/Email.php

Delete the code in red:

    protected function _getRecentPublicThreads()
    {
        $nodeModel = $this->getModelFromCache('XenForo_Model_Node');
        $nodes = $nodeModel->getAllNodes(false, true);
        $nodePermissions = $nodeModel->getNodePermissionsForPermissionCombination(1);
        
        $nodeHandlers = $nodeModel->getNodeHandlersForNodeTypes(
            $nodeModel->getUniqueNodeTypeIdsFromNodeList($nodes)
        );
        
        $nodes = $nodeModel->getViewableNodesFromNodeList($nodes, $nodeHandlers, $nodePermissions);
        
        $options = XenForo_Application::get('options');
        
        foreach ($nodes as $node)
        {
            $nodeIds[] = $node['node_id'];
        }
       
        $conditions = array(
            'node_id' => $nodeIds);
           
        $fetchOptions = array(
            'order' => 'post_date',
            'limit' => $options->monthlyEmailsThreadLimit);
       
        $threadModel = $this->getModelFromCache('XenForo_Model_Thread');
       
        $threads = $threadModel->getThreads($conditions, $fetchOptions);
       
        return $threads;
    }

In its place, add:

            $nodeIds = array(
                '2',
                '3',
                '4'
            );

The resulting code will look like:

    protected function _getRecentPublicThreads()
    {
        $nodeIds = array(
            '2',
            '3',
            '4'
        );
       
        $conditions = array(
            'node_id' => $nodeIds);
           
        $fetchOptions = array(
            'order' => 'post_date',
            'limit' => $options->monthlyEmailsThreadLimit);
       
        $threadModel = $this->getModelFromCache('XenForo_Model_Thread');
       
        $threads = $threadModel->getThreads($conditions, $fetchOptions);
       
        return $threads;
    }

Does this code still work to restrict it to certain forums?

 

[cmeinck]

You'll have to increase the max_execution time for PHP. I've run into this as well on larger sites.

Do you have any specific recommendations for a site with roughly 300k members?

 

[cmeinck]

I've installed BD Mail and use Mandrill. Is it safe to send out? I'm sure that with the first run, I'll get a few spam reports and plenty of bounces.

Thoughts? What's the best solution?

Also, does this add-on pull threads that are admin-only? I installed XFLetter and it showed moderator threads.

 

[Code Monkey]

This does not seem to check for Valid member. It sends it to "awaiting email confirmation (from edit) which is not "Valid".

 

[Chris D]

Well done, @Code Monkey you may have uncovered a bug.

        $users = $this->getModelFromCache('XenForo_Model_User')->getUsers(array(
            'user_status' => 'valid',
            'receive_admin_email' => 1,
            'is_banned' => 0,
        ), array(
            'join' => XenForo_Model_User::FETCH_USER_FULL
        ));

Should be:

        $users = $this->getModelFromCache('XenForo_Model_User')->getUsers(array(
            'user_state' => 'valid',
            'receive_admin_email' => 1,
            'is_banned' => 0,
        ), array(
            'join' => XenForo_Model_User::FETCH_USER_FULL
        ));

 

[Code Monkey]

Sweet thanks. With a 10 year old site I have lot's of dead emails. I will see how it works next month.

 

[Brent W]

I'll update the package soon

 

[Brent W]

BamaStangGuy updated Latest Threads Monthly Email with a new update entry:

Bug Fix

Fixes issue where email was being sent to unconfirmed accounts.

Read the rest of this update entry...

 

[Rho Delta]

This won't email out threads from private sections will it? How do you configure what date it will send out the email? Looking forward to testing this out!

 

[MotMann]

Nice add-on. But what happened to change the phrases forever?

 

[jauburn]

Anyone get into trouble with spam complaints or blacklisting as a result of this? Is there an unsubscribe link?

Also, is there a way to send the mail only to active users, those who have been around in the past month or two? I saw someone else earlier ask about this, but I did not see a response.

Thanks!

 

[Brent W]

Anyone get into trouble with spam complaints or blacklisting as a result of this? Is there an unsubscribe link?

Also, is there a way to send the mail only to active users, those who have been around in the past month or two? I saw someone else earlier ask about this, but I did not see a response.

Thanks!

I have made a change to the template so that at the end it offers the user a way to unsubscribe. Will update this shortly.

 

[Brent W]

BamaStangGuy updated Latest Threads Monthly Email with a new update entry:

Add unsubscribe text

At the end of the email a line of text will explain how to stop receiving the monthly emails.

View attachment 63891

Read the rest of this update entry...

 

[Brent W]

There is an issue that will require another update I just noticed. Give me a few more...

 

[Brent W]

BamaStangGuy updated Latest Threads Monthly Email with a new update entry:

Fixed Link Issue

Fixed unsubscribe link

Read the rest of this update entry...

 

[Code Monkey]

Awesome. However I'm pretty sure there are specifics that are required by email host that need to be included in the text.

 

[jauburn]

Awesome. However I'm pretty sure there are specifics that are required by email host that need to be included in the text.

Generally you're supposed to have an unsubscribe link and a physical address (p.o. box being okay) in newsletters.

This is from Mailchimp, which is parrotting the can-spam guidelines:

You must include your contact information inside every promotional email that you send, including a physical mailing address where you can receive mail or a PO Box. (Not a website or email address.)