Fixed Javascript error on xfInsert

[sonnb]

Hello,

There are some users might experience with javascript error on xfInsert event. This might occur on new reply or after inline-edit the post. The post disappear but could not be shown again.

The javascript console would show:

NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 0 [nsIDOMWindow.getComputedStyle]

...conds();wa=na.getUTCMilliseconds();}na=(pa<=0||pa>=10000?(pa<0?"-":"+")+o(6,pa<0...

This kind of error does not occur on all browsers, this might cause by jQuery library or conflict with another library.

After investigate I see that in XF source code:

xfInsert: function(insertMethod, insertReference, animateMethod, animateSpeed, callback)
        {
            if (insertMethod == 'replaceAll')
            {
                $(insertReference).xfFadeUp(animateSpeed);
            }
 
            this
                .addClass('__XenForoActivator')
                .hide()
                [insertMethod || 'appendTo'](insertReference)
                .xfActivate()
                [animateMethod || 'xfFadeDown'](animateSpeed, callback);
 
            return this;
        },

You could see that XF would hide the element first then later use fadeDown function to use show up animation.

This could be easy resolved by change

hide() to .css('display', 'none)

This is strange since hide() function is shortcut to set css display property to none. But I think in the next version, we should use css('display', 'none) instead of hide() to avoid this kind of problem.

 

[Luân Vũ]

As you can see in the source of jQuery 1.5.0: http://james.padolsey.com/jquery/#v=1.5.0&fn=hide
the $.fn.hide method not only set the style display of elements to none, but also save their old display.
I think it's good for $.fn.show method to set the property display to exact value!

 

[Marcus]

Also got this error: http://xenforo.com/community/threads/contentloader-not-working.40279/#post-438437

 

[sonnb]

It's odd but hope Mike would fix this in 1.1.4.

 

[Marcus]

maybe it's something they will fix when they will use a newer jquery library, most likely not in a minor release as 1.1.x. More likely in a 1.x release.

 

[HWS]

We also got reports from users about that error.

 

[soloman]

me too

 

[shenmuee]

+1 me too

 

[Marcus]

Then let's vote on the first post so our developers know which bugs may have priority.

 

[Paul B]

Neither liking nor bumping bug reports is necessary.

They will all be dealt with in due course.

 

[Mike]

I think this change should be ok - the animate function has various code in it to determine which display to move to. Though if someone had a consistent reproduction case, that'd be helpful.