1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Issue with viewing soft deleted messages

Discussion in 'Resolved Bug Reports' started by Deebs, Mar 9, 2011.

  1. Deebs

    Deebs Well-Known Member

    If I soft delete a message and then click "Show" it takes forever and an age for it to be displayed. I get the little activity display in the top right corner then about 15-20 seconds it actually shows the message.

    One of my mods was also performing some testing with soft deleted messages and said the following:

     
  2. Kier

    Kier XenForo Developer Staff Member

    Can you consistently reproduce this on all threads, or just one in particular? Have you tried different browsers?
     
  3. Deebs

    Deebs Well-Known Member

    Let me go play... brb
     
    Vincent likes this.
  4. Deebs

    Deebs Well-Known Member

    Ok,

    Tried FireFox 3.6.8 and IE 8 across threads with 3 posts, 100 posts and greater than 500 posts. The results are consistent. It takes forever to "Show" the message, deleting the message is instant, undeleting the message is also instant.
     
  5. Deebs

    Deebs Well-Known Member

    My mod has just replied with

     
  6. Kier

    Kier XenForo Developer Staff Member

    We'd likely need to see this in action. Could you PM login details?
     
  7. Deebs

    Deebs Well-Known Member

    Details on their way...
     
  8. Kier

    Kier XenForo Developer Staff Member

    I tried this on a 5.5m post db and :eek: yes, you're right!

    Thankfully we've found the problem and it was a relatively easy fix.
     
    SneakyDave likes this.
  9. Kier

    Kier XenForo Developer Staff Member

    If anyone else with a very large number of posts is affected by this, you can apply the following fix:

    XenForo_ControllerPublic_Thread, line 292, change this:
    PHP:
    $postIds preg_replace('/^post-(\d+)$/''\1'$postIds);
    to this
    PHP:
    $postIds array_map('intval'preg_replace('/^post-(\d+)$/''\1'$postIds));
     

Share This Page