• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

XF 1.2 Small issue with viewing unread posts

Rudy

Well-known member
#1
When you click on a thread title, you are usually jumped to the point in the thread which the first unread post is located.

Since the 1.2 upgrade, our big board has had some users report that instead of jumping to the first unread post, they are jumping to the bottom of the page.

Template or JavaScript issue, perhaps? I did revert or merge templates where needed, but I don't think I touched the template that builds the thread view page.

Any clue where I can look, or should I just revert everything and play it safe?

JQuery wouldn't be doing this, would it? I have the forum set to use Google's CDN to deliver the JQuery. We are also not using anything like CloudFlare--everything is self hosted.
 

Jeremy

Well-known member
#3
The link should be /unread for each title which gets redirected to a specific post. If anything, they should remain at the top.

jQuery doesn't interact with this portions. Does the URL end in #post-#?
 

Rudy

Well-known member
#4
I merged one or two templates that had some minor modifications, but reverted all of the rest when I did the upgrade. I'm thinking I might have to revert those I merged or customized over the past few years and start from scratch.
 

AndyB

Well-known member
#5
I merged one or two templates that had some minor modifications, but reverted all of the rest when I did the upgrade. I'm thinking I might have to revert those I merged or customized over the past few years and start from scratch.
Yes it's safest to revert all templates. When I make a template modification, I always include comments so I can quickly reproduce the changes. I save a copy of each modified template in a simple text file.
 

Rudy

Well-known member
#6
The link should be /unread for each title which gets redirected to a specific post. If anything, they should remain at the top.

jQuery doesn't interact with this portions. Does the URL end in #post-#?
I'll have to check those URL issues. Thing is, it's working OK for me, so I can't really duplicate it to find out. I'll ask around though!

I agree--if a link isn't exactly right on a page, I've seen the same thing--they usually remain at the top of the page.
 

Rudy

Well-known member
#7
Yes it's safest to revert all templates. When I make a template modification, I always include comments so I can quickly reproduce the changes. I save a copy of each modified template in a simple text file.
One thought: there is an option to turn on serving templates from the filesystem as opposed to the database. Would that be a source of trouble? I enabled it after I did the upgrade to XF1.2, though, but I'm going to disable it anyway until I figure out what's going wrong.
 

AndyB

Well-known member
#8
One thought: there is an option to turn on serving templates from the filesystem as opposed to the database. Would that be a source of trouble? I enabled it after I did the upgrade to XF1.2, though, but I'm going to disable it anyway until I figure out what's going wrong.
I see no speed improvement in serving templates from the file system, it would be safer to have it served from the database.
 

Rudy

Well-known member
#10
You only get a speed improvement from storing them as files if you have some sort of caching mechanism running.
Yep, got two actually. (y) APC and memcache for different (and numerous) chores on the server. APC was a huge lifesaver on our old forum with vB. Dropped our loads in half!
 

Rudy

Well-known member
#12
I'm pretty much convinced it is template related. I just have to find time to redo all of that work. :) What I really want to do is replace the direct template edits with entries I'd make in the new template modification system. I used it for one modification using a simple search and replace, and it worked fantastic! It gives me the freedom to try out new ideas in the template without bringing down the whole forum. ;)
 

Rudy

Well-known member
#13
Found it!

I had a xen: conditional at the top and bottom of the page_container template that left an unclosed <div> on the page. Fixed that and it's working properly now.
 

Rudy

Well-known member
#14
There is a similar problem now: if you are viewing a thread and click on the "Next" link, some users are reporting they jump to the bottom of the following page instead of the top.

I can't duplicate it myself. My only thought is that it might be a plugin since I now have hardly any modified templates (the only one with a couple of additions is EXTRA.css).
 

Amaury

Well-known member
#15
There is a similar problem now: if you are viewing a thread and click on the "Next" link, some users are reporting they jump to the bottom of the following page instead of the top.

I can't duplicate it myself. My only thought is that it might be a plugin since I now have hardly any modified templates (the only one with a couple of additions is EXTRA.css).
Any plugins related to posting?
 

Rudy

Well-known member
#16
Any plugins related to posting?
Nothing that I can see. I have Waindigo's Newest Post First add-on installed; I'd disable it to see if that were causing the problem, but since I can't duplicate the problem, there is no way for me to check.
 

Amaury

Well-known member
#17
Nothing that I can see. I have Waindigo's Newest Post First add-on installed; I'd disable it to see if that were causing the problem, but since I can't duplicate the problem, there is no way for me to check.
Try disabling that and see if the user that reported it still has problems.