Fixed Infinite HTTP requests : running AJAX job.php

[Chris D]

Good to know.

@Nirjonadda @Breixo @The Dark Wizard do either of you use any of the add-ons mentioned, perhaps most particularly Tapatalk?

I'm not so sure User Mentions Improvements is related as most stuck jobs I've seen don't exclusively contain mention alerts, but please do list any add-ons so we can see if there's a pattern.

 

[Breixo]

Good to know.

@Nirjonadda @Breixo @The Dark Wizard do either of you use any of the add-ons mentioned, perhaps most particularly Tapatalk?

I'm not so sure User Mentions Improvements is related as most stuck jobs I've seen don't exclusively contain mention alerts, but please do list any add-ons so we can see if there's a pattern.

Using both addons.
I'll send a list with all I use at the moment via PM.
Thanks for your reply.

 

[The Dark Wizard]

I don't use Tapatalk but I do use that addon by @Xon and several others. When we did the whole process of truncating and duplicating the table, it started to get better. Though we are still not aware of what caused it to begin with and if it will happen again.

 

[wakon5544]

@Chris D



Only this addon xengentr widget system only

 

[wakon5544]

@Chris D
my topic views not working now because xf_job template emptied. this caused the problem. have you found any solution?

 

[wakon5544]

The problem has improved when I removed this code. I do it once now I do not know what caused it. There may be a problem when we passed 1.5 version.

 

[Xon]

I'm not so sure User Mentions Improvements is related as most stuck jobs I've seen don't exclusively contain mention alerts, but please do list any add-ons so we can see if there's a pattern.

User Mentions Improvements kicks stuff to a job faster than XF standard, but it doesn't touch the job continue/finish logic.

 

[shining]

Just found out that I have the same problem

But I don´t really understand what to do now.... can someone please explain for non-mysql-experts?

Oder gibt es hier jemanden der mitliest und mir die Lösung auf deutsch erklären kann?
(Or can someone explain this to me in german?)

 

[shining]

Currently the recommended workaround is to duplicate your xf_job table (and its contents e.g. xf_job_bak) and then empty/truncate the original table.

Now it seems like the cron jobs stopped working
Next run for all is frozen to 17.7. but we already have 20.07.

The date even does not change if I click on "Run now" .

 

[wakon5544]

Now it seems like the cron jobs stopped working
Next run for all is frozen to 17.7. but we already have 20.07.

The date even does not change if I click on "Run now" .

• XenForo can be reinstalled
• Connect phpmyadmin export job.sql
• Your xenforo import again.
• Have fun

problem originated from the XF: Notifier table written in job.sql.

@Chris D needs to examine and fix it.

 

[Breixo]

I'm still getting this error. Hope @Chris D or someone fix it.
Though Xf2.0.8 was going to have this fixed but...

 

[Ghan_04]

We're also having this issue again. Other than once again purging the jobs table in the database, I don't know what to do about it. I know very little about the inner workings of xenForo, and there is no documentation on how the jobs manager works, so I would have an incredibly difficult time trying to track down what is happening.

 

[Breixo]

We're also having this issue again. Other than once again purging the jobs table in the database, I don't know what to do about it. I know very little about the inner workings of xenForo, and there is no documentation on how the jobs manager works, so I would have an incredibly difficult time trying to track down what is happening.

Hope they find the way to solve this soon.

 

[Chris D]

So far not seeing anything obvious from the databases that I've had access to.

If it happens again, this time instead of clearing the job table, please submit a new ticket (or reply to an existing one if you have one open) and provide your FTP, Admin CP and database (PhpMyAdmin is ideal) login details and we'll dive deeper into the code to find the problem/cause.

 

[Xon]

This is a bug introduced in XF 2.0.5 when the "Watched Thread" notifier was made to be conditionally loaded by XF\Service\Post\Notifier

Problem code in XF\Service\AbstractNotifier

    public function hasMore()
    {
        $this->ensureDataLoaded();

        foreach ($this->notifyData AS $type => $toProcess)
        {
            if ($toProcess)
            {
                return true;
            }
        }

        return false;
    }

Fix:

    public function hasMore()
    {
        $this->ensureDataLoaded();
      
        foreach ($this->getNotifiers() AS $type => $notifier)
        {
            if (!empty($this->notifyData[$type]))
            {
                return true;
            }
        }

        return false;
    }

 

[GSCimbom]

Thank you

 

[Breixo]

This is a bug introduced in XF 2.0.5 when the "Watched Thread" notifier was made to be conditionally loaded by XF\Service\Post\Notifier

Problem code in XF\Service\AbstractNotifier

    public function hasMore()
    {
        $this->ensureDataLoaded();

        foreach ($this->notifyData AS $type => $toProcess)
        {
            if ($toProcess)
            {
                return true;
            }
        }

        return false;
    }

Fix:

    public function hasMore()
    {
        $this->ensureDataLoaded();
     
        foreach ($this->getNotifiers() AS $type => $notifier)
        {
            if (!empty($this->notifyData[$type]))
            {
                return true;
            }
        }

        return false;
    }

Tried but got several errors:

ErrorException: [E_WARNING] Invalid argument supplied for foreach() src/XF/Service/AbstractNotifier.php:146

ErrorException: [E_NOTICE] Undefined property: SV\UserMentionsImprovements\XF\Service\Post\Notifier::$getNotifiers src/XF/Service/AbstractNotifier.php:146

 

[Xon]

@Breixo what version of php? Try this instead

    public function hasMore()
    {
        $this->ensureDataLoaded();
        $notifiers = $this->getNotifiers();
        if (!$notifiers)
        {
            return false;
        }

        foreach ($notifiers AS $type => $notifier)
        {
            if (!empty($this->notifyData[$type]))
            {
                return true;
            }
        }

        return false;
    }

 

[Breixo]

@Breixo what version of php? Try this instead

    public function hasMore()
    {
        $this->ensureDataLoaded();
        $notifiers = $this->getNotifiers();

        foreach ($notifiers AS $type => $notifier)
        {
            if (!empty($this->notifyData[$type]))
            {
                return true;
            }
        }

        return false;
    }

PHP 7.x

 

[Claudio]

PHP 7.x

Your path is
SV\UserMentionsImprovements

That's not correct