1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Incorrect signature for XenForo_Model_Attachment::prepareAttachmentConditions

Discussion in 'Resolved Bug Reports' started by xfrocks, Oct 6, 2011.

  1. xfrocks

    xfrocks Well-Known Member

    Version: 1.1 beta
    Class: XenForo_Model_Attachment
    Line: 276

    public function prepareAttachmentConditions(array $conditions, array $fetchOptions)
    Should be

    public function prepareAttachmentConditions(array $conditions, array &$fetchOptions)
    For 2 reasons:
    1. To match with the convention in other models
    2. To allow conditions to trigger fetch options (like adding a join)
    Hope this will be fixed :)
    erich37, Veer and Digital Doctor like this.
  2. Kier

    Kier XenForo Developer Staff Member

    Not really a bug as such, but worth changing nonetheless.

    (Which I've done)
    M@rc and xfrocks like this.

Share This Page