Fixed Incorrect ArrayCollection type-hint on some methods


Well-known member
Affected version
2.2.8 Patch 1
The following methods are type hinted as ArrayCollection which should be AbstractCollection as they can return FinderCollection;
  • \XF\Mvc\Entity\Finder::getIterator
  • \XF\Mvc\Entity\Manager::findByIds
\XF\Mvc\Entity\Manager also has the methods getBasicCollection and getEmptyCollection which probably should be type hinted AbstractCollection as well.
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.13).

Change log:
Fix some entity collection return type hints
There may be a delay before changes are rolled out to the XenForo Community.
Top Bottom