Incorrect ArrayCollection type-hint on some methods

Xon

Well-known member
Affected version
2.2.8 Patch 1
The following methods are type hinted as ArrayCollection which should be AbstractCollection as they can return FinderCollection;
  • \XF\Mvc\Entity\Finder::getIterator
  • \XF\Mvc\Entity\Manager::findByIds
\XF\Mvc\Entity\Manager also has the methods getBasicCollection and getEmptyCollection which probably should be type hinted AbstractCollection as well.
 
Top