Fixed addContentToBookmarks uses ArrayCollection instead of AbstractCollection for type hint

[Xon]

Affected version

2.3.0

XF\Repository\BookmarkRepository::addContentToBookmarks's argument is type hinted as @param ArrayCollection|BookmarkItem[]. This could be replaced with or AbstractCollection<BookmarkItem>|BookmarkItem[] just AbstractCollection<BookmarkItem>.

This enables passing finder results straight to this method without static analysis raising a false positive

There are actually a few places which use @param ArrayCollection| which could get the same treatment.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.4).

Change log:

Use AbstractCollection for type hint on addContentToBookmarks method

There may be a delay before changes are rolled out to the XenForo Community.