1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Inconsistent use of phrase in conversation edit overlay

Discussion in 'Resolved Bug Reports' started by Luxus, May 30, 2013.

  1. Luxus

    Luxus Well-Known Member

    This is the link group in conversation view:
    conv.png

    When you click at "Edit Conversation" you get this overlay:

    overlay.png

    As you can see, the phrase "Edit Conversation" is used as a text for the button as well. This is inconsistent with the phrase "Save Changes" that is used elsewhere throughout the system, for example, when editing threads. Therefore I suggest using "Save Changes" for the button:

    overlay2.png
     
  2. Luxus

    Luxus Well-Known Member

    I have found another instance where "Save Changes" is more appropriate:

    poll.png
     
    Alluidh and Alien like this.
  3. Mike

    Mike XenForo Developer Staff Member

    Strictly speaking, it's not inconsistent with the system in general. You'll see buttons like "Move Thread", "Delete Thread", "Unwatch Forum", etc. However, I agree that in the simple edit case, "save changes" is probably more consistent.
     

Share This Page