Fixed Import from SMF wrong birthdays?

[Mr. Jinx]

I did a (test) import with SMF 2.0.13 data. Not sure if this is a bug or something else so I'll post it here.
Birthdays are not imported properly. Most of them are imported with year 1900 and a wrong month/day.

This is probably a date conversion thing. Anyone know about this?

 

[Chris D]

What is the format of birth dates for the users in the SMF database which haven't been imported correctly?

 

[Mr. Jinx]

It's stored as "year-month-date".
Example: 1974-05-22

 

[Chris D]

Hmm, our code expects it to be "day-month-year", e.g. 22-05-1974

Do you know if this is something that has changed in recent years, or is configurable by the admin or can be stored differently based on localisation settings?

 

[Mr. Jinx]

Nope, I'm pretty sure this has been the default for SMF, even for the 1.x branche.
In MySQL it uses the DATE type, which defaults to YYYY-MM-DD. There is no setting in SMF that changes this.
An example function that uses the birthday variable in SMF: http://support.simplemachines.org/function_db/index.php?action=view_function;id=882

Then again, why did nobody complain about this before... weird.

 

[Chris D]

Then again, why did nobody complain about this before... weird.

This is definitely the important question. I don't recall that being mentioned before, which is bizarre as it has almost certainly been wrong for 2.5 years.

Hence why I assumed there must be some change or some setting (which would be especially odd considering its purpose).

Anyway, if you wanted to fix this for yourself and do the import again:

In library/XenForo/Importer/SMF.php change:

if (trim($parts[2]) != '0001')

To:

if (trim($parts[0]) != '0001')

Change:

$import['dob_day'] = trim($parts[0]);

To:

$import['dob_day'] = trim($parts[2]);

Change:

$import['dob_year'] = trim($parts[2]);

To:

$import['dob_year'] = trim($parts[0]);

And that should fix it.

If you're not planning to do another import, can you confirm what the dob_day, dob_month and dob_year fields have been imported as in XF? I'm hoping 1974, 5 and 22 respectively. If that's the case, we might be able to direct a SQL query to fix them, otherwise they'll be stuck like that or need resetting.

 

[Mr. Jinx]

Great, thanks!
I'm going to run a new import and will use this. Should do the job.

 

[Bionic Rooster]

Then again, why did nobody complain about this before... weird.

This is definitely the important question. I don't recall that being mentioned before, which is bizarre as it has almost certainly been wrong for 2.5 years.

I can confirm that when I converted several years ago all dates were converted correctly. I don't remember what version of SMF I was converting from at the time but the converter worked correctly at that time.

 

[marquisite]

I get funky birthdates Xenforo after an SMF 2.0.13 import, too. Just like @Mr. Jinx , the smf_members.birthdate column is in a YYYY-MM-DD format. I have been making preparations to migrate from SMF since February and thought, given the silence about importing birthdays, that it must've just been a quirk with my instance of SMF. Up to now I've run queries to update the xf_user_profile dob year/month/day columns after import, but I'll give the Importer/SMF.php edits a shot as it will save some time - thanks @Chris D .

SMF stores some birthdays with the year '0004', in cases where somebody has entered their birthday with the year omitted. Looking at Importer/SMF.php this doesn't appear to be taken into consideration. I'm guessing all this probably needs is the following condition added before $import['dob_year']:

if (trim($parts[0]) != '0004')

 

[Mr. Jinx]

The fix from Chris D worked for me. I also had some birthdays with 0004 and changed those manually.
I also had some other problems with the importer, not related to birthdays. Maybe I'll write a small 'lessons learned' or something about my experiences.

 

[marquisite]

The fix from Chris D worked for me. I also had some birthdays with 0004 and changed those manually.
I also had some other problems with the importer, not related to birthdays. Maybe I'll write a small 'lessons learned' or something about my experiences.

Yeah I also have to run my own queries for user timezones as they don't import from SMF correctly either, with many defaulting to "Atlantic/Reykjavik" and not the SMF configured server time "Australia/Sydney" (although this is getting off topic sorry).

 

[imno007]

For what it's worth, I have SMF 2.1 Beta 2 installed for a site and the default birthdate format is definitely 0001-01-01.

 

[Chris D]

The birthdate issue and birthdate without a year issue is resolved for the next release. Many thanks.