alexm
Active member
Don't know whether it's of help but I'm using an old version of Image Optimizer (2.0.8) and I've got jpegoptim v.1.4.6 and no bug that I'm aware of.
Image Optimizer for XF 2.0 [Paid] 2.1.8
- Thread starter truonglv
- Start date
Don't know whether it's of help but I'm using an old version of Image Optimizer (2.0.8) and I've got jpegoptim v.1.4.6 and no bug that I'm aware of.
truonglv
Well-known member
This error when add-on try to get file path from your database. It look likes you have it broken before.
MattW
Well-known member
How can the database be broken? The file is being deleted from the file system, and the file works and loads before the addon does what it does (and it's only jpeg and not png files).
https://xenforo.com/community/threads/image-optimizer-for-xf-2-0-paid.140261/page-30#post-1663754Please read the above post I made which details exactly what is happening.
Your addon changes the HASH used on the file, the original is deleted, but the optimised version is never written back to the file system.
Last edited:
Moshe1010
Well-known member
Did it help to upgrade?
What seems to help me with these errors is enabling this option in add-on's settings in ACP:
MattW
Well-known member
Seeing this on a 3rd site now:
www.retrobike.co.uk
I've changed it also to optimise on the fly, rather than on cron.
Site Suggestions (and Issues) Thread
Has anyone noticed that some uploaded images don’t seem to be showing, just in the last week? When I was posting the botm poll I had to screen grab the image of one of the bikes and use that, as the original image I saved wouldn’t display. I thought it was a one off but I’ve seen it a few more...
www.retrobike.co.uk
I've changed it also to optimise on the fly, rather than on cron.
mcatze
Well-known member
I've got an error with the IO-Test.
I tried the attached image.
Code:
LogicException: Failed to optimize image in src/addons/Truonglv/ImageOptimizer/XF/Admin/Controller/Tools.php at line 208
Truonglv\ImageOptimizer\XF\Admin\Controller\Tools->actionIOTest() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 258
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2487
XF\App->run() in src/XF.php at line 524
XF::runApp() in admin.php at line 13I tried the attached image.
Attachments
MattW
Well-known member
https://xenforo.com/community/threads/image-optimizer-for-xf-2-0-paid.140261/page-30#post-1663754Looks like there is something really not quite right with how this is working at the minute, and the fact it's trashing attachments is VERY worrying.
truonglv
Well-known member
Do you use external storage?
Ivancas
Well-known member
Something tells me you don't have any idea where to start investigating. You are not asking for login credentials or any way to troubleshoot this on your end.
MattW
Well-known member
Have you actually read my posts? I've explained that this has been observed with both local storage, and external storage.
truonglv
Well-known member
What processor you use for JPEG? jpegoptim or webp? In 2.1.8 we just only support webp. The core still same.
MattW
Well-known member
Again, please read my actual posts. I've already said jpegoptim. Please also don't ignore the other people who are reporting this same issue.
Chris2
Member
I'll try to detail our situation. We are using version 2.1.8, with jpedoptim 1.4.6. We first started running it a few weeks ago, without the webp enabled. When the optimization was complete, I didn't notice any deleted jpgs. Around a week later, I decided to try the webp optimization to further compress the images. This leads up to recently, when I checked this thread and decided to dig deeper. I then noticed LOTS of missing jpg files and disabled the addon.
Is it possible that the addon only deletes jpg files when webp is enabled? Optimization on the fly must be turned off also, for webp to operate, which was turned on the first run. As @truonglv mentioned, the core didn't change in 2.1.8 and 2.1.7 seems fine. That would lead me to believe that the webp feature is the culprit?
I've checked with my host and they have a backup of the attachments folders from before I turned on webp, so is the only solution a restore of those missing files at this point? I've checked the attachment folders for the front end missing images and they're definitely not there...
Is it possible that the addon only deletes jpg files when webp is enabled? Optimization on the fly must be turned off also, for webp to operate, which was turned on the first run. As @truonglv mentioned, the core didn't change in 2.1.8 and 2.1.7 seems fine. That would lead me to believe that the webp feature is the culprit?
I've checked with my host and they have a backup of the attachments folders from before I turned on webp, so is the only solution a restore of those missing files at this point? I've checked the attachment folders for the front end missing images and they're definitely not there...
MattW
Well-known member
and to add to yours, none of the sites I've seen this on have webp enabled.
Chris2
Member
Geez, we might be out of luck then, as our host only has backups up until the first run without webp was completed. Might it be possible that the lost files are in a /trash folder somewhere? I've looked, but don't see any images in the .trash. This is outrageous.
