Lack of interest Hyperlink Facebook and Twitter identities

[rfc0001]

Would by nice to have a URL to Facebook and Twitter for Facebook and Twitter identities when users click on a profile > About. Simple change to custom_fields_macros:

<xf:macro name="custom_field_value" arg-definition="!" arg-value="!">
    <xf:if is="$definition.field_type == 'stars'">
        <xf:macro template="rating_macros" name="stars" arg-rating="{$value}" />
    <xf:else />
        <xf:if is="$definition.match_type == 'date'">
            <xf:macro name="custom_field_value_date" arg-date="{$value}" />
        <xf:elseif is="$definition.match_type == 'color'" />
            <xf:macro name="custom_field_value_color" arg-color="{$value}" />
        <xf:elseif is="$definition.title == 'Facebook'" />
            <a href="https://www.facebook.com/{$definition.getFormattedValue($value)}">https://www.facebook.com/{$definition.getFormattedValue($value)}</a>
        <xf:elseif is="$definition.title == 'Twitter'" />
            <a href="https://twitter.com/{$definition.getFormattedValue($value)}">https://twitter.com/{$definition.getFormattedValue($value)}</a>
        <xf:else />
            {$definition.getFormattedValue($value)|raw}
        </xf:if>
    </xf:if>
</xf:macro>

 

[Chris D]

Probably doesn't need a template edit. That's what the "Value display HTML" field is for. It's just a case of whether we implement it by default, or call it implemented already on the basis that it can be changed if people want them to be links.

 

[rfc0001]

Thanks, I wasn't aware of this option. Agree that would be a better implementation.

Either way - my suggestion is this should be hyperlinked by default. Not much value having a facebook "token" without the URL. Most users won't figure out they need to append that to https://www.facebook.com. Having it hyperlinked by default makes it intuitive to just click on it.